From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B4B4C433EF for ; Mon, 25 Oct 2021 09:34:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEA2F60EFF for ; Mon, 25 Oct 2021 09:34:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEA2F60EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mewNY-0003zp-Kb for qemu-devel@archiver.kernel.org; Mon, 25 Oct 2021 05:34:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mewLs-0002tB-0t for qemu-devel@nongnu.org; Mon, 25 Oct 2021 05:33:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mewLn-0001FJ-Fv for qemu-devel@nongnu.org; Mon, 25 Oct 2021 05:33:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635154381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gyHbIAEmzb305hMpHypKfjq2PwK766HVEVZ79xk65c=; b=Vt1mSO0htxSVF3tQ9V7P+3OekjThxCIzNtQOzlLOp117mzuWkJRk7dee1nEGQJ7NRaSm+p OGS7W47oVHBtOVvUiTUFYiBFJf01Zr5PAkKK8yeQ9ifxELCEp0oRroXuVr2ruQUQgodVjp fcUlT2qVSnml3Iua5KqV3bJI3FBI6LI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-xddTXZryP0ue7gNYB54YUw-1; Mon, 25 Oct 2021 05:32:56 -0400 X-MC-Unique: xddTXZryP0ue7gNYB54YUw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 642A98026AD; Mon, 25 Oct 2021 09:32:55 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3AB5A1948C; Mon, 25 Oct 2021 09:32:54 +0000 (UTC) Date: Mon, 25 Oct 2021 11:32:52 +0200 From: Kevin Wolf To: Fabrice Fontaine Subject: Re: [PATCH] block/export/fuse.c: fix musl build Message-ID: References: <20211022095209.1319671-1-fontaine.fabrice@gmail.com> MIME-Version: 1.0 In-Reply-To: <20211022095209.1319671-1-fontaine.fabrice@gmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hanna Reitz , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 22.10.2021 um 11:52 hat Fabrice Fontaine geschrieben: > Include linux/falloc.h if CONFIG_FALLOCATE_ZERO_RANGE is defined to fix > https://gitlab.com/qemu-project/qemu/-/commit/50482fda98bd62e072c30b7ea73c985c4e9d9bbb > and avoid the following build failure on musl: > > ../block/export/fuse.c: In function 'fuse_fallocate': > ../block/export/fuse.c:643:21: error: 'FALLOC_FL_ZERO_RANGE' undeclared (first use in this function) > 643 | else if (mode & FALLOC_FL_ZERO_RANGE) { > | ^~~~~~~~~~~~~~~~~~~~ > > Fixes: > - http://autobuild.buildroot.org/results/be24433a429fda681fb66698160132c1c99bc53b > > Signed-off-by: Fabrice Fontaine This patches makes sense to me, but does this mean that commit 50482fda was completely untested and the build still failed after the patch? If so, is at least this one tested and builds successfully now? Kevin