From: Kevin Wolf <kwolf@redhat.com>
To: Hanna Reitz <hreitz@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] block-backend: Silence clang -m32 compiler warning
Date: Tue, 2 Nov 2021 13:22:27 +0100 [thread overview]
Message-ID: <YYEtg9PkLt/0J+ut@redhat.com> (raw)
In-Reply-To: <20211026090745.30800-1-hreitz@redhat.com>
Am 26.10.2021 um 11:07 hat Hanna Reitz geschrieben:
> Similarly to e7e588d432d31ecebc26358e47201dd108db964c, there is a
> warning in block/block-backend.c that qiov->size <= INT64_MAX is always
> true on machines where size_t is narrower than a uint64_t. In said
> commit, we silenced this warning by casting to uint64_t.
>
> The commit introducing this warning here
> (a93d81c84afa717b0a1a6947524d8d1fbfd6bbf5) anticipated it and so tried
> to address it the same way. However, it only did so in one of two
> places where this comparison occurs, and so we still need to fix up the
> other one.
>
> Fixes: a93d81c84afa717b0a1a6947524d8d1fbfd6bbf5
> ("block-backend: convert blk_aio_ functions to int64_t bytes
> paramter")
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2021-11-02 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:07 [PATCH] block-backend: Silence clang -m32 compiler warning Hanna Reitz
2021-10-26 10:31 ` Philippe Mathieu-Daudé
2021-11-02 12:22 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYEtg9PkLt/0J+ut@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).