From: Kashyap Chamarthy <kchamart@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
qemu-trivial@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, "Laurent Vivier" <Laurent@vivier.eu>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH v2 0/6] rSTify contribution-related wiki pages
Date: Tue, 2 Nov 2021 16:51:08 +0100 [thread overview]
Message-ID: <YYFebObSyo6itE/R@paraplu> (raw)
In-Reply-To: <CAFEAcA8CHVfAXFaQwfZrQUfJcD9qQNOYAEt9vvpQVtgwtTf80w@mail.gmail.com>
On Mon, Nov 01, 2021 at 02:56:43PM +0000, Peter Maydell wrote:
> On Tue, 19 Oct 2021 at 10:04, Kashyap Chamarthy <kchamart@redhat.com> wrote:
> >
> > My main motivation was to convert SubmitAPatch[1] based on a chat with
> > Peter Maydell and Dan Berrangé on #qemu channel (on OFTC). But the page
> > also links to a couple of other contribution-related pages, so I
> > converted them too:
> >
> > - SubmitAPullRequest: https://wiki.qemu.org/Contribute/SubmitAPullRequest
> > - KeySigningParty: https://wiki.qemu.org/KeySigningParty
> > - SpellCheck: https://wiki.qemu.org/Contribute/SpellCheck
> > - TrivialPatches: https://wiki.qemu.org/Contribute/TrivialPatches
>
> I'm not sure that SpellCheck in particular is sufficiently baked
> to be in the actual docs. I'd rather just drop the reference to it
> from SubmitAPatch.
Sure, will drop.
> KeySigningParty I'm on the fence about.
This is linked only from the SubmitAPullRequest page. If we're
ambivalent about it, I'll just keep it in for reference.
I'll also fix the index-updating part you caught in your other review.
Thanks for the review.
--
/kashyap
next prev parent reply other threads:[~2021-11-02 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 9:03 [PATCH v2 0/6] rSTify contribution-related wiki pages Kashyap Chamarthy
2021-10-19 9:03 ` [PATCH v2 1/6] docs: rSTify the "TrivialPatches" wiki Kashyap Chamarthy
2021-10-19 9:18 ` Laurent Vivier
2021-10-19 11:55 ` Kashyap Chamarthy
2021-10-19 9:03 ` [PATCH v2 2/6] docs: rSTify the "SpellCheck" wiki Kashyap Chamarthy
2021-10-19 11:16 ` Philippe Mathieu-Daudé
2021-10-19 9:03 ` [PATCH v2 3/6] docs: rSTify the "KeySigningParty" wiki Kashyap Chamarthy
2021-10-19 9:03 ` [PATCH v2 4/6] docs: rSTify the "SubmitAPullRequest" wiki Kashyap Chamarthy
2021-10-19 11:13 ` Philippe Mathieu-Daudé
2021-10-19 9:03 ` [PATCH v2 5/6] docs: rSTify the "SubmitAPatch" wiki Kashyap Chamarthy
2021-10-19 9:03 ` [PATCH v2 6/6] docs/devel: Update the rST index file Kashyap Chamarthy
2021-11-01 14:57 ` Peter Maydell
2021-10-19 9:11 ` [PATCH v2 0/6] rSTify contribution-related wiki pages Kashyap Chamarthy
2021-11-01 14:56 ` Peter Maydell
2021-11-02 15:51 ` Kashyap Chamarthy [this message]
2021-11-08 15:16 ` Thomas Huth
2021-11-08 18:22 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYFebObSyo6itE/R@paraplu \
--to=kchamart@redhat.com \
--cc=Laurent@vivier.eu \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).