From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A164C433F5 for ; Mon, 8 Nov 2021 13:58:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6B8D61181 for ; Mon, 8 Nov 2021 13:58:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6B8D61181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mk5A2-0002f0-W5 for qemu-devel@archiver.kernel.org; Mon, 08 Nov 2021 08:58:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk568-0006K9-1X for qemu-devel@nongnu.org; Mon, 08 Nov 2021 08:54:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk55z-000844-2l for qemu-devel@nongnu.org; Mon, 08 Nov 2021 08:54:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636379637; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=RdY2QV6iwq5O4fESY05Q/r4tpTzeyx9MkjEfOngDSLA=; b=TKL2tkBvr97ns+HsL9x3bEvkA61ix/7tBoMaLYG0ZQ9+4McvwF/f01EYOtRMJSjUUYU0gu iaHIm3C8yMep7585UEtA2OE0xOBrHwWVVEnAp1CWZGigZBcOkMqzztsxrcIFQi8Muam+dE +FxJxJC/UBs9KdIDJPFGgSJ4z9oFO4U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-598-_dW2YHZKPRG3YV2geMUkMA-1; Mon, 08 Nov 2021 08:53:44 -0500 X-MC-Unique: _dW2YHZKPRG3YV2geMUkMA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA4D8100E3E6; Mon, 8 Nov 2021 13:53:42 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D089B62A44; Mon, 8 Nov 2021 13:53:39 +0000 (UTC) Date: Mon, 8 Nov 2021 13:53:37 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dov Murik Subject: Re: [PATCH v2 3/6] target/i386/sev: Rephrase error message when no hashes table in guest firmware Message-ID: References: <20211108134840.2757206-1-dovmurik@linux.ibm.com> <20211108134840.2757206-4-dovmurik@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <20211108134840.2757206-4-dovmurik@linux.ibm.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Tom Lendacky , Ashish Kalra , Brijesh Singh , Eduardo Habkost , Eric Blake , James Bottomley , Marcelo Tosatti , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Tobin Feldman-Fitzthum , Gerd Hoffmann , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Nov 08, 2021 at 01:48:37PM +0000, Dov Murik wrote: > Signed-off-by: Dov Murik > --- > target/i386/sev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/i386/sev.c b/target/i386/sev.c > index e3abbeef68..c71d23654f 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -1232,7 +1232,8 @@ bool sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp) > } > > if (!pc_system_ovmf_table_find(SEV_HASH_TABLE_RV_GUID, &data, NULL)) { > - error_setg(errp, "SEV: kernel specified but OVMF has no hash table guid"); > + error_setg(errp, "SEV: -kernel specified but guest firmware " > + "has no hashes table GUID"); Don't refer to "-kernel" as that's just one way to specifying it. The user might have used -machine ....,kernel=/path/to/vmlinux Simply "kernel" as the original text has, is fine. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|