From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D770C433EF for ; Tue, 9 Nov 2021 14:32:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 522CB6112D for ; Tue, 9 Nov 2021 14:32:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 522CB6112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:32888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkSAN-0000mv-6H for qemu-devel@archiver.kernel.org; Tue, 09 Nov 2021 09:32:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkS8n-0007Sv-3D for qemu-devel@nongnu.org; Tue, 09 Nov 2021 09:30:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkS8h-00085y-LD for qemu-devel@nongnu.org; Tue, 09 Nov 2021 09:30:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636468218; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=LO6OdymyeVYfZZMtnSlrDXOsRCCkq3iuB8vANm8ubZI=; b=i33VEYZIMWBMqt972coT7e411bji/aYJWzn7n4e/TW6eGV+Czg++SbM/VvkJnDGIMSxXHe 9c6FwoivFjE+IC7p+nPHAOlmGeGmgf942gQgi67nCkcXR9KI9ULfbIi7hiZdMQbVCdbLCO 2daiSX2r5xkKzpbMu+49BMfiS6ytxeM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-f81lIR03Mx21YLaMr3dLww-1; Tue, 09 Nov 2021 09:29:55 -0500 X-MC-Unique: f81lIR03Mx21YLaMr3dLww-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7292F8015BA; Tue, 9 Nov 2021 14:29:54 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.190]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A18119C79; Tue, 9 Nov 2021 14:29:29 +0000 (UTC) Date: Tue, 9 Nov 2021 14:29:26 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Michael S. Tsirkin" Subject: Re: [PATCH v2 3/3] tests: acpi: Add updated TPM related tables Message-ID: References: <20211109140152.3310657-1-stefanb@linux.ibm.com> <20211109140152.3310657-4-stefanb@linux.ibm.com> <20211109091338-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: <20211109091338-mutt-send-email-mst@kernel.org> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Ani Sinha , marcandre.lureau@redhat.com, Igor Mammedov , qemu-devel@nongnu.org, Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Nov 09, 2021 at 09:14:25AM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 09, 2021 at 09:01:52AM -0500, Stefan Berger wrote: > > The updated TPM related tables have the following additions: > > > > Device (TPM) > > { > > Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */) // _HID: Hardware ID > > + Name (_STR, "TPM 2.0 Device") // _STR: Description String > > + Name (_UID, One) // _UID: Unique ID > > Name (_STA, 0x0F) // _STA: Status > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > Cc: Michael S. Tsirkin > > Cc: Igor Mammedov > > Cc: Ani Sinha > > Signed-off-by: Stefan Berger > > --- > > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 0 -> 8900 bytes > > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 0 -> 8921 bytes > > tests/data/acpi/q35/TCPA.tis.tpm12 | Bin 0 -> 50 bytes > > tests/data/acpi/q35/TPM2.tis.tpm2 | Bin 0 -> 76 bytes > > tests/qtest/bios-tables-test-allowed-diff.h | 11 ----------- > > 5 files changed, 11 deletions(-) > > A disadvantage to doing it like this is that git thinks > it's ok to replace any empty file with this, so if acpi > changed in any way git will happily resolve it > replacing it with this version. Do we actually need to be storing these binary files in git at all ? IIUC, the test will do two things - memcmp the expected binary we store, against the new binary we generated. - if they differ, then disassemble both and report the differences in a user friendly-ish way What if we only stored the sha256 checksum of the binary *and* the dissasembled output in git, never the full binary. IIUC, that would give us the same level of diagnostic output from the test failures. The dissasembled output would then give us meaningful patches for reviewers to look at. The author wouldn't have to describe the difference in the commit message as Stefan has (helpfully) done here. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|