From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84B4C433FE for ; Wed, 17 Nov 2021 14:47:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D5C861C4F for ; Wed, 17 Nov 2021 14:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D5C861C4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnMDk-0003RG-Ba for qemu-devel@archiver.kernel.org; Wed, 17 Nov 2021 09:47:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnMCm-0002N1-0c for qemu-devel@nongnu.org; Wed, 17 Nov 2021 09:46:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:25051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnMCi-0000d5-LP for qemu-devel@nongnu.org; Wed, 17 Nov 2021 09:46:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637160388; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=smEZ1/pdrC6k4DK218s69AL6Y2CI25CKISa/c8K4aS4=; b=DYAAEUvbNSF7S+yNwT0dJi+mF/0l/YLeSeQMAtzP0rWEnFLlIosS/DLaQhimJWAwsn06sl +PpfaDpBv1lsyHXNdD+R6GaeHO3BfDQFrBI5kJo331Id+4eqW94gEmpGR3TZx0mei0nxeq vJXSGs0ehRqSvEBxRkGWllFNK6zTeCY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-Zkz37Gb-OhupnCjiklPsjw-1; Wed, 17 Nov 2021 09:46:26 -0500 X-MC-Unique: Zkz37Gb-OhupnCjiklPsjw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9EBD87D542; Wed, 17 Nov 2021 14:46:25 +0000 (UTC) Received: from redhat.com (unknown [10.22.16.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95F1E60BF1; Wed, 17 Nov 2021 14:46:24 +0000 (UTC) Date: Wed, 17 Nov 2021 14:46:22 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Subject: Re: Failing QEMU iotests Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.701, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Hanna Reitz , John Snow , QEMU Developers , Qemu-block Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 17, 2021 at 01:50:12PM +0100, Thomas Huth wrote: > On 17/11/2021 11.59, Hanna Reitz wrote: > > On 17.11.21 11:07, Thomas Huth wrote: > > > > > >  Hi! > > > > > > I think it has been working fine for me a couple of weeks ago, > > > but when I now run: > > > > > >  make check SPEED=slow > > > > > > I'm getting a couple of failing iotests... not sure whether > > > these are known issues already, so I thought I'd summarize them > > > here: > ... > > > --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out > > > +++ 206.out.bad > > > @@ -99,55 +99,19 @@ > > > > > >  {"execute": "blockdev-create", "arguments": {"job-id": "job0", > > > "options": {"driver": "qcow2", "encrypt": {"cipher-alg": > > > "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg": > > > "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg": > > > "md5", "key-secret": "keysec0"}, "file": {"driver": "file", > > > "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}} > > >  {"return": {}} > > > +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode > > >  {"execute": "job-dismiss", "arguments": {"id": "job0"}} > > >  {"return": {}} > > > > > >  image: TEST_IMG > > >  file format: IMGFMT > > >  virtual size: 32 MiB (33554432 bytes) > > > -encrypted: yes > > >  cluster_size: 65536 > > >  Format specific information: > > >      compat: 1.1 > > >      compression type: zlib > > >      lazy refcounts: false > > >      refcount bits: 16 > > > -    encrypt: > > > -        ivgen alg: plain64 > > > -        hash alg: sha1 > > > -        cipher alg: twofish-128 > > > -        uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX > > > -        format: luks > > > -        cipher mode: ctr > > > -        slots: > > > -            [0]: > > > -                active: true > > > -                iters: XXX > > > -                key offset: 4096 > > > -                stripes: 4000 > > > -            [1]: > > > -                active: false > > > -                key offset: 69632 > > > -            [2]: > > > -                active: false > > > -                key offset: 135168 > > > -            [3]: > > > -                active: false > > > -                key offset: 200704 > > > -            [4]: > > > -                active: false > > > -                key offset: 266240 > > > -            [5]: > > > -                active: false > > > -                key offset: 331776 > > > -            [6]: > > > -                active: false > > > -                key offset: 397312 > > > -            [7]: > > > -                active: false > > > -                key offset: 462848 > > > -        payload offset: 528384 > > > -        master key iters: XXX > > >      corrupt: false > > >      extended l2: false > > > > I doubt this worked a couple of weeks ago, but it’s definitely one that > > we should just get around to fixing. :/ > > Hm, maybe I've did the successful run on a different system last time ... I > even slightly remember now having seen this before in the past on my current > system, so yes, likely not something new. Triggered by me switching QEMU to prefer GNUTLS for crypto by default in 6.1, as it doesn't bother to support obscure crypto algs that no one uses in practice for LUKS. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|