qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kashyap Chamarthy <kchamart@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'
Date: Mon, 22 Nov 2021 13:59:52 +0100	[thread overview]
Message-ID: <YZuUSOrmJY7iCSZz@paraplu> (raw)
In-Reply-To: <c591c571-f922-28a5-e8be-75e6cccb261a@redhat.com>

On Mon, Nov 22, 2021 at 01:36:53PM +0100, Thomas Huth wrote:
> On 22/11/2021 13.19, Kashyap Chamarthy wrote:

[...]

> > I kept that because an explicit reminder about spell-check is useful;
> > it's easy to forget.  Another option is to retain the line, but replace
> > "See also:" with "And:".  Not sure if it's any better.  But I don't mind
> > either way.
> 
> What about simply replacing it with a new sentence below the bullet list,
> saying:
> 
> "Please also use a spell checker like `codespell
> https://github.com/codespell-project/codespell` with your patches"
> 
> ?

Sounds good to me; go for it.  Thanks!

-- 
/kashyap



  reply	other threads:[~2021-11-22 13:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 19:31 [PATCH 0/2] Fix broken rST conversion of "submitting-a-patch.rst" Kashyap Chamarthy
2021-11-19 19:31 ` [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst' Kashyap Chamarthy
2021-11-22  9:51   ` Thomas Huth
2021-11-22 10:20     ` Kashyap Chamarthy
2021-11-22 10:36       ` Thomas Huth
2021-11-22 12:19         ` Kashyap Chamarthy
2021-11-22 12:36           ` Thomas Huth
2021-11-22 12:59             ` Kashyap Chamarthy [this message]
2021-11-22 13:25             ` Peter Maydell
2021-11-22 13:30               ` Thomas Huth
2021-11-22 13:33                 ` Daniel P. Berrangé
2021-11-22 13:38                   ` Thomas Huth
2021-11-22 13:53                 ` Peter Maydell
2021-11-22 14:01                   ` Thomas Huth
2021-11-22 14:45                     ` Kashyap Chamarthy
2021-11-19 19:31 ` [PATCH 2/2] docs: List more commit-message tags "in submitting-a-patch" Kashyap Chamarthy
2021-11-19 20:19 ` [PATCH 0/2] Fix broken rST conversion of "submitting-a-patch.rst" Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZuUSOrmJY7iCSZz@paraplu \
    --to=kchamart@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).