qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: huangy81@chinatelecom.cn
Cc: "Juan Quintela" <quintela@redhat.com>,
	"Markus ArmBruster" <armbru@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v7 0/3] support dirty restraint on vCPU
Date: Tue, 30 Nov 2021 20:57:47 +0800	[thread overview]
Message-ID: <YaYfy7YqZpOopold@xz-m1.local> (raw)
In-Reply-To: <cover.1638267778.git.huangy81@chinatelecom.cn>

On Tue, Nov 30, 2021 at 06:28:10PM +0800, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> 
> The patch [2/3] has not been touched so far. Any corrections and
> suggetions are welcome. 

I played with it today, but the vcpu didn't got throttled as expected.

What I did was starting two workload with 500mb/s, each pinned on one vcpu
thread:

[root@fedora ~]# pgrep -fa mig_mon
595 ./mig_mon mm_dirty 1000 500 sequential
604 ./mig_mon mm_dirty 1000 500 sequential
[root@fedora ~]# taskset -pc 595
pid 595's current affinity list: 2
[root@fedora ~]# taskset -pc 604
pid 604's current affinity list: 3

Then start throttle with 100mb/s:

(QEMU) set-dirty-limit cpu-index=3 dirty-rate=100
{"return": {}}
(QEMU) set-dirty-limit cpu-index=2 dirty-rate=100
{"return": {}}

I can see the workload dropped a tiny little bit (perhaps 500mb -> 499mb), then
it keeps going..

Further throttle won't work too:

(QEMU) set-dirty-limit cpu-index=2 dirty-rate=10
{"return": {}}

Funnily, the ssh client got slowed down instead... :(

Yong, how did you test it?

-- 
Peter Xu



  parent reply	other threads:[~2021-11-30 12:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 10:28 [PATCH v7 0/3] support dirty restraint on vCPU huangy81
     [not found] ` <cover.1638267948.git.huangy81@chinatelecom.cn>
2021-11-30 10:28   ` [PATCH v7 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically huangy81
2021-11-30 13:04     ` Peter Xu
2021-11-30 15:10       ` Hyman Huang
2021-11-30 10:28   ` [PATCH v7 2/3] cpu-throttle: implement vCPU throttle huangy81
2021-11-30 10:28   ` [PATCH v7 3/3] cpus-common: implement dirty page limit on vCPU huangy81
2021-11-30 13:21     ` Peter Xu
2021-11-30 15:25       ` Hyman Huang
2021-12-02 16:02     ` Markus Armbruster
2021-12-03  1:19       ` Hyman Huang
2021-11-30 12:57 ` Peter Xu [this message]
2021-11-30 14:57   ` [PATCH v7 0/3] support dirty restraint " Hyman Huang
2021-11-30 16:04     ` Hyman Huang
  -- strict thread matches above, loose matches on Subject: below --
2021-11-29 16:17 huangy81

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaYfy7YqZpOopold@xz-m1.local \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).