From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, danielhb413@gmail.com,
Leandro Lupori <leandro.lupori@eldorado.org.br>,
qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH v4] target/ppc: fix Hash64 MMU update of PTE bit R
Date: Wed, 1 Dec 2021 10:42:08 +1100 [thread overview]
Message-ID: <Yaa20FBX6F7xagx9@yekko> (raw)
In-Reply-To: <62188dd4-c6ea-4c3e-b444-585319818b4f@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
On Tue, Nov 30, 2021 at 09:44:58AM +0100, Cédric le Goater wrote:
> On 11/30/21 01:30, David Gibson wrote:
> > On Mon, Nov 29, 2021 at 03:57:51PM -0300, Leandro Lupori wrote:
> > > When updating the R bit of a PTE, the Hash64 MMU was using a wrong byte
> > > offset, causing the first byte of the adjacent PTE to be corrupted.
> > > This caused a panic when booting FreeBSD, using the Hash MMU.
> > >
> > > Fixes: a2dd4e83e76b ("ppc/hash64: Rework R and C bit updates")
> > > Signed-off-by: Leandro Lupori <leandro.lupori@eldorado.org.br>
> >
> > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> Sorry, I didn't wait for your Rb because the patch was a good candidate
> for -rc3. It is merged now.
No worries.
>
> > Thanks for your patience with our nitpicking :).
>
> Yes,
>
> Here is another QEMU bug found by FreeBSD :
> https://lore.kernel.org/qemu-devel/427ef2ee-6871-0d27-f485-90ad142f6266@kaod.org/
>
> It would be interesting to boot directly the PowerNV machine from a
> FreeBSB kernel and a minimum inirtd without using the skiroot images
> and an iso. Are images available ?
>
> Thanks.
>
> C.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-01 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 18:57 [PATCH v4] target/ppc: fix Hash64 MMU update of PTE bit R Leandro Lupori
2021-11-30 0:30 ` David Gibson
2021-11-30 8:44 ` Cédric Le Goater
2021-11-30 20:00 ` Leandro Lupori
2021-12-01 7:51 ` Cédric Le Goater
2021-12-01 12:37 ` Leandro Lupori
2021-11-30 23:42 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yaa20FBX6F7xagx9@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=leandro.lupori@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).