From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Henry Kleynhans <hkleynhans@fb.com>
Cc: Henry Kleynhans <henry.kleynhans@gmail.com>,
"henry.kleynhans@fb.com" <henry.kleynhans@fb.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] Relax X509 CA cert sanity checking
Date: Tue, 14 Dec 2021 15:00:09 +0000 [thread overview]
Message-ID: <YbixeezdNHXgRwWv@redhat.com> (raw)
In-Reply-To: <BY5PR15MB35728B48C640AC319375D99AB8759@BY5PR15MB3572.namprd15.prod.outlook.com>
On Tue, Dec 14, 2021 at 02:55:02PM +0000, Henry Kleynhans wrote:
> Hi Daniel,
>
> I agree that this would allow QEMU startup with a broken
> TLS setup. Maybe the better solution is to only validate
> the chain of trust. Would a patch that does that be acceptable?
Yes, that would be fine. It was only ever intended to validate
the chain of trust needed for QEMU's usage. It simply never
occurred to me that someone who have extra redundant certs in
their bundle, so I didn't do anything special to handle that.
BTW, there's a decent amount of unit test coverage for this code
in tests/unit/test-crypto-tlscredsx509.c which could be fairly
easily extended to cover the scenarios of extra certs outside
the required chain of trust.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-12-14 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 11:39 [PATCH] Relax X509 CA cert sanity checking Henry Kleynhans
2021-12-14 13:04 ` Philippe Mathieu-Daudé
2021-12-14 13:16 ` Daniel P. Berrangé
2021-12-14 14:55 ` Henry Kleynhans
2021-12-14 15:00 ` Daniel P. Berrangé [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-14 10:03 Henry Kleynhans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbixeezdNHXgRwWv@redhat.com \
--to=berrange@redhat.com \
--cc=henry.kleynhans@fb.com \
--cc=henry.kleynhans@gmail.com \
--cc=hkleynhans@fb.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).