From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] block/file-posix: Simplify the XFS_IOC_DIOINFO handling
Date: Thu, 16 Dec 2021 10:59:20 +0100 [thread overview]
Message-ID: <YbsN+C/rNx6xE2Un@redhat.com> (raw)
In-Reply-To: <20211215125824.250091-1-thuth@redhat.com>
Am 15.12.2021 um 13:58 hat Thomas Huth geschrieben:
> The handling for the XFS_IOC_DIOINFO ioctl is currently quite excessive:
> This is not a "real" feature like the other features that we provide with
> the "--enable-xxx" and "--disable-xxx" switches for the configure script,
> since this does not influence lots of code (it's only about one call to
> xfsctl() in file-posix.c), so people don't gain much with the ability to
> disable this with "--disable-xfsctl".
> It's also unfortunate that the ioctl will be disabled on Linux in case
> the user did not install the right xfsprogs-devel package before running
> configure. Thus let's simplify this by providing the ioctl definition
> on our own, so we can completely get rid of the header dependency and
> thus the related code in the configure script.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2021-12-16 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 12:58 [PATCH] block/file-posix: Simplify the XFS_IOC_DIOINFO handling Thomas Huth
2021-12-16 9:59 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbsN+C/rNx6xE2Un@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).