From: David Gibson <david@gibson.dropbear.id.au>
To: Fabiano Rosas <farosas@linux.ibm.com>
Cc: richard.henderson@linaro.org, danielhb413@gmail.com,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org
Subject: Re: [PATCH v2 6/7] target/ppc: Use ppc_interrupts_little_endian in powerpc_excp
Date: Thu, 6 Jan 2022 16:31:27 +1100 [thread overview]
Message-ID: <YdZ+r2rYXoerdeUO@yekko> (raw)
In-Reply-To: <20220105204029.4058500-7-farosas@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2337 bytes --]
On Wed, Jan 05, 2022 at 05:40:28PM -0300, Fabiano Rosas wrote:
> The ppc_interrupts_little_endian function is now suitable for
> determining the endianness of interrupts for all CPUs.
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Nice!
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> target/ppc/excp_helper.c | 29 +----------------------------
> 1 file changed, 1 insertion(+), 28 deletions(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 92953af896..d16bdf9283 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -833,36 +833,9 @@ static void powerpc_excp(PowerPCCPU *cpu, int excp)
> * Sort out endianness of interrupt, this differs depending on the
> * CPU, the HV mode, etc...
> */
> -#ifdef TARGET_PPC64
> - if (excp_model == POWERPC_EXCP_POWER7) {
> - if (!(new_msr & MSR_HVB) && (env->spr[SPR_LPCR] & LPCR_ILE)) {
> - new_msr |= (target_ulong)1 << MSR_LE;
> - }
> - } else if (excp_model == POWERPC_EXCP_POWER8) {
> - if (new_msr & MSR_HVB) {
> - if (env->spr[SPR_HID0] & HID0_HILE) {
> - new_msr |= (target_ulong)1 << MSR_LE;
> - }
> - } else if (env->spr[SPR_LPCR] & LPCR_ILE) {
> - new_msr |= (target_ulong)1 << MSR_LE;
> - }
> - } else if (excp_model == POWERPC_EXCP_POWER9 ||
> - excp_model == POWERPC_EXCP_POWER10) {
> - if (new_msr & MSR_HVB) {
> - if (env->spr[SPR_HID0] & HID0_POWER9_HILE) {
> - new_msr |= (target_ulong)1 << MSR_LE;
> - }
> - } else if (env->spr[SPR_LPCR] & LPCR_ILE) {
> - new_msr |= (target_ulong)1 << MSR_LE;
> - }
> - } else if (msr_ile) {
> + if (ppc_interrupts_little_endian(cpu, !!(new_msr & MSR_HVB))) {
> new_msr |= (target_ulong)1 << MSR_LE;
> }
> -#else
> - if (msr_ile) {
> - new_msr |= (target_ulong)1 << MSR_LE;
> - }
> -#endif
>
> #if defined(TARGET_PPC64)
> if (excp_model == POWERPC_EXCP_BOOKE) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-06 5:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 20:40 [PATCH v2 0/7] target/ppc: powerpc_excp improvements (2/n) Fabiano Rosas
2022-01-05 20:40 ` [PATCH v2 1/7] target/ppc: powerpc_excp: Extract software TLB logging into a function Fabiano Rosas
2022-01-06 3:55 ` David Gibson
2022-01-07 1:37 ` Richard Henderson
2022-01-05 20:40 ` [PATCH v2 2/7] target/ppc: powerpc_excp: Keep 60x soft MMU logs active Fabiano Rosas
2022-01-06 5:26 ` David Gibson
2022-01-07 1:40 ` Richard Henderson
2022-01-05 20:40 ` [PATCH v2 3/7] target/ppc: powerpc_excp: Group unimplemented exceptions Fabiano Rosas
2022-01-06 5:26 ` David Gibson
2022-01-07 3:07 ` Richard Henderson
2022-01-05 20:40 ` [PATCH v2 4/7] target/ppc: Add HV support to ppc_interrupts_little_endian Fabiano Rosas
2022-01-06 5:30 ` David Gibson
2022-01-06 13:05 ` Cédric Le Goater
2022-01-05 20:40 ` [PATCH v2 5/7] target/ppc: Add MSR_ILE " Fabiano Rosas
2022-01-06 5:30 ` David Gibson
2022-01-05 20:40 ` [PATCH v2 6/7] target/ppc: Use ppc_interrupts_little_endian in powerpc_excp Fabiano Rosas
2022-01-06 5:31 ` David Gibson [this message]
2022-01-05 20:40 ` [PATCH v2 7/7] target/ppc: Introduce a wrapper for powerpc_excp Fabiano Rosas
2022-01-06 5:31 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdZ+r2rYXoerdeUO@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=farosas@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).