From: Stefan Hajnoczi <stefanha@redhat.com>
To: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: "marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
"david@redhat.com" <david@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"raphael.s.norwitz@gmail.com" <raphael.s.norwitz@gmail.com>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots
Date: Mon, 10 Jan 2022 11:24:52 +0000 [thread overview]
Message-ID: <YdwXhDdUjk5H9pmF@stefanha-x1.localdomain> (raw)
In-Reply-To: <20220106064717.7477-5-raphael.norwitz@nutanix.com>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Thu, Jan 06, 2022 at 06:47:35AM +0000, Raphael Norwitz wrote:
> When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to
> libvhost-user, no guardrails were added to protect against QEMU
> attempting to hot-add too many RAM slots to a VM with a libvhost-user
> based backed attached.
>
> This change adds the missing error handling by introducing a check on
> the number of RAM slots the device has available before proceeding to
> process the VHOST_USER_ADD_MEM_REG message.
>
> Suggested-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
> ---
> subprojects/libvhost-user/libvhost-user.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-10 11:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 6:47 [PATCH v2 0/5] Clean up error handling in libvhost-user memory mapping Raphael Norwitz
2022-01-06 6:47 ` [PATCH v2 1/5] libvhost-user: Add vu_rem_mem_reg input validation Raphael Norwitz
2022-01-10 8:56 ` David Hildenbrand
2022-01-10 9:36 ` Michael S. Tsirkin
2022-01-10 19:43 ` Raphael Norwitz
2022-01-10 21:11 ` Michael S. Tsirkin
2022-01-11 9:13 ` Stefan Hajnoczi
2022-01-06 6:47 ` [PATCH v2 2/5] libvhost-user: Add vu_add_mem_reg " Raphael Norwitz
2022-01-10 8:56 ` David Hildenbrand
2022-01-06 6:47 ` [PATCH v2 3/5] libvhost-user: Simplify VHOST_USER_REM_MEM_REG Raphael Norwitz
2022-01-06 6:47 ` [PATCH v2 4/5] libvhost-user: prevent over-running max RAM slots Raphael Norwitz
2022-01-10 8:57 ` David Hildenbrand
2022-01-10 9:40 ` Michael S. Tsirkin
2022-01-10 22:38 ` Raphael Norwitz
2022-01-10 11:24 ` Stefan Hajnoczi [this message]
2022-01-06 6:47 ` [PATCH v2 5/5] libvhost-user: handle removal of identical regions Raphael Norwitz
2022-01-10 8:58 ` David Hildenbrand
2022-01-10 22:38 ` Raphael Norwitz
2022-01-10 11:25 ` Stefan Hajnoczi
2022-01-10 9:01 ` [PATCH v2 0/5] Clean up error handling in libvhost-user memory mapping David Hildenbrand
2022-01-10 22:36 ` Raphael Norwitz
2022-01-10 11:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdwXhDdUjk5H9pmF@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=david@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=raphael.s.norwitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).