From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, michael.roth@amd.com,
philmd@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
hreitz@redhat.com, pbonzini@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH v2 4/4] meson: generate trace points for qmp commands
Date: Mon, 10 Jan 2022 16:27:07 +0000 [thread overview]
Message-ID: <YdxeWwMGUJZLrf/s@stefanha-x1.localdomain> (raw)
In-Reply-To: <20211223110756.699148-5-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Thu, Dec 23, 2021 at 12:07:56PM +0100, Vladimir Sementsov-Ogievskiy wrote:
> 1. Use --add-trace-points when generate qmp commands
> 2. Add corresponding .trace-events files as outputs in qapi_files
> custom target
> 3. Define global qapi_trace_events list of .trace-events file targets,
> to fill in trace/qapi.build and to use in trace/meson.build
> 4. In trace/meson.build use the new array as an additional source of
> .trace_events files to be processed
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> meson.build | 1 +
> qapi/meson.build | 9 ++++++++-
> trace/meson.build | 11 ++++++++---
> 3 files changed, 17 insertions(+), 4 deletions(-)
This patch has a meson subdir ordering dependency: qapi/ must be
processed before trace/. Please document this in meson.build so anyone
editing subdirs knows to preserve this order.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-01-10 16:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 11:07 [PATCH v2 0/4] trace qmp commands Vladimir Sementsov-Ogievskiy
2021-12-23 11:07 ` [PATCH v2 1/4] jobs: drop qmp_ trace points Vladimir Sementsov-Ogievskiy
2022-01-10 16:05 ` Stefan Hajnoczi
2022-01-11 23:44 ` John Snow
2022-01-12 10:45 ` Stefan Hajnoczi
2021-12-23 11:07 ` [PATCH v2 2/4] scripts/qapi/commands: gen_commands(): add add_trace_points argument Vladimir Sementsov-Ogievskiy
2022-01-10 16:22 ` Stefan Hajnoczi
2022-01-17 8:46 ` Vladimir Sementsov-Ogievskiy
2022-01-11 23:53 ` John Snow
2022-01-12 0:32 ` John Snow
2022-01-12 10:50 ` Stefan Hajnoczi
2022-01-17 8:45 ` Vladimir Sementsov-Ogievskiy
2022-01-17 9:31 ` Kevin Wolf
2021-12-23 11:07 ` [PATCH v2 3/4] scripts/qapi-gen.py: add --add-trace-points option Vladimir Sementsov-Ogievskiy
2022-01-10 16:22 ` Stefan Hajnoczi
2022-01-12 0:38 ` John Snow
2022-01-17 8:50 ` Vladimir Sementsov-Ogievskiy
2021-12-23 11:07 ` [PATCH v2 4/4] meson: generate trace points for qmp commands Vladimir Sementsov-Ogievskiy
2022-01-10 16:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdxeWwMGUJZLrf/s@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).