qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Leonardo Bras <leobras@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
	qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v7 4/5] migration: Add migrate_use_tls() helper
Date: Thu, 13 Jan 2022 13:10:59 +0000	[thread overview]
Message-ID: <YeAk48s3ckQrd1F0@redhat.com> (raw)
In-Reply-To: <20220106221341.8779-5-leobras@redhat.com>

On Thu, Jan 06, 2022 at 07:13:41PM -0300, Leonardo Bras wrote:
> A lot of places check parameters.tls_creds in order to evaluate if TLS is
> in use, and sometimes call migrate_get_current() just for that test.
> 
> Add new helper function migrate_use_tls() in order to simplify testing
> for TLS usage.
> 
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration.h | 1 +
>  migration/channel.c   | 6 +++---
>  migration/migration.c | 9 +++++++++
>  migration/multifd.c   | 5 +----
>  4 files changed, 14 insertions(+), 7 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2022-01-13 13:16 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 22:13 [PATCH v7 0/5] MSG_ZEROCOPY + multifd Leonardo Bras
2022-01-06 22:13 ` [PATCH v7 1/5] QIOChannel: Add flags on io_writev and introduce io_flush callback Leonardo Bras
2022-01-13  6:28   ` Peter Xu
2022-01-18 20:45     ` Leonardo Bras Soares Passos
2022-01-19  1:58       ` Peter Xu
2022-01-19 18:29         ` Leonardo Bras Soares Passos
2022-01-13 10:52   ` Daniel P. Berrangé
2022-01-19  4:38     ` Leonardo Bras Soares Passos
2022-01-06 22:13 ` [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX Leonardo Bras
2022-01-13  6:48   ` Peter Xu
2022-01-13 10:06     ` Daniel P. Berrangé
2022-01-13 10:34       ` Peter Xu
2022-01-13 10:42         ` Daniel P. Berrangé
2022-01-13 12:12           ` Peter Xu
2022-01-19 17:23             ` Leonardo Bras Soares Passos
2022-01-19 17:22           ` Leonardo Bras Soares Passos
2022-01-20  1:28             ` Peter Xu
2022-01-19 17:16         ` Leonardo Bras Soares Passos
2022-01-19 17:01     ` Leonardo Bras Soares Passos
2022-02-01  4:23     ` Leonardo Bras Soares Passos
2022-01-13 13:05   ` Daniel P. Berrangé
2022-01-19 17:24     ` Leonardo Bras Soares Passos
2022-01-06 22:13 ` [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux Leonardo Bras
2022-01-13  7:00   ` Peter Xu
2022-01-19 17:53     ` Leonardo Bras Soares Passos
2022-01-13 13:09   ` Daniel P. Berrangé
2022-01-19 18:03     ` Leonardo Bras Soares Passos
2022-01-19 18:15       ` Daniel P. Berrangé
2022-01-19 18:46         ` Leonardo Bras Soares Passos
2022-02-18 16:31           ` Juan Quintela
2022-02-21 16:23             ` Leonardo Bras Soares Passos
2022-01-06 22:13 ` [PATCH v7 4/5] migration: Add migrate_use_tls() helper Leonardo Bras
2022-01-13  7:02   ` Peter Xu
2022-01-19 18:06     ` Leonardo Bras Soares Passos
2022-01-20  1:37       ` Peter Xu
2022-01-13 13:10   ` Daniel P. Berrangé [this message]
2022-01-19 18:07     ` Leonardo Bras Soares Passos
2022-01-06 22:13 ` [PATCH v7 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy) Leonardo Bras
2022-01-13  7:15   ` Peter Xu
2022-01-19 18:23     ` Leonardo Bras Soares Passos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeAk48s3ckQrd1F0@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).