From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EEB7C433EF for ; Wed, 19 Jan 2022 09:51:40 +0000 (UTC) Received: from localhost ([::1]:41018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nA7cx-0001kJ-Gq for qemu-devel@archiver.kernel.org; Wed, 19 Jan 2022 04:51:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nA7TH-0000Hp-UD for qemu-devel@nongnu.org; Wed, 19 Jan 2022 04:41:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nA7TF-0004Ws-BO for qemu-devel@nongnu.org; Wed, 19 Jan 2022 04:41:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642585296; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YoOlwC1ebxmE3Q5l4ioy0+TD5kN0VhA+WNMGTD/1bZI=; b=GAIzgUnw13Q6jVV/mvKZrbXvH0GMtY6xsJfSLasvI+VVt3+AVlsVNd3E8gKKXkBzrLoIZE NcKvxoAXE14D5T4S83IsUO8Rw6R6AFD0BGTUjo319n/PtaAnDb9cycn8V45JnST4Ls+4Vo bjvjZ/ahRtU51NakHAfJq4/DC4X5evc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-499-xN__6raZMAKHUHexJwMj-Q-1; Wed, 19 Jan 2022 04:41:35 -0500 X-MC-Unique: xN__6raZMAKHUHexJwMj-Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65B96102CB73; Wed, 19 Jan 2022 09:41:24 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.213]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B1204F87A; Wed, 19 Jan 2022 09:41:23 +0000 (UTC) Date: Wed, 19 Jan 2022 09:41:20 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yang Zhong Subject: Re: [PATCH] qapi: Cleanup SGX related comments Message-ID: References: <20220119120014.342180-1-yang.zhong@intel.com> <20220119092259.GA25040@yangzhon-Virtual> MIME-Version: 1.0 In-Reply-To: <20220119092259.GA25040@yangzhon-Virtual> User-Agent: Mutt/2.1.3 (2021-09-10) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: pbonzini@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jan 19, 2022 at 05:22:59PM +0800, Yang Zhong wrote: > On Wed, Jan 19, 2022 at 09:16:46AM +0000, Daniel P. Berrangé wrote: > > On Wed, Jan 19, 2022 at 07:00:14AM -0500, Yang Zhong wrote: > > > The SGX NUMA patches were merged into Qemu 7.0 release, we need > > > clarify detailed version history information and also change > > > some related comments, which make SGX related comments clearer. > > > > > > Signed-off-by: Yang Zhong > > > --- > > > qapi/machine.json | 4 ++-- > > > qapi/misc-target.json | 14 +++++++++----- > > > 2 files changed, 11 insertions(+), 7 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé > > > > > diff --git a/qapi/machine.json b/qapi/machine.json > > > index b6a37e17c4..cf47cb63a9 100644 > > > --- a/qapi/machine.json > > > +++ b/qapi/machine.json > > > @@ -1207,7 +1207,7 @@ > > > # > > > # @memdev: memory backend linked with device > > > # > > > -# @node: the numa node > > > +# @node: the numa node (Since: 7.0) > > > # > > > # Since: 6.2 > > > ## > > > @@ -1288,7 +1288,7 @@ > > > # > > > # @memdev: memory backend linked with device > > > # > > > -# @node: the numa node > > > +# @node: the numa node (Since: 7.0) > > > # > > > # Since: 6.2 > > > ## > > > diff --git a/qapi/misc-target.json b/qapi/misc-target.json > > > index 1022aa0184..558521bd39 100644 > > > --- a/qapi/misc-target.json > > > +++ b/qapi/misc-target.json > > > @@ -344,9 +344,9 @@ > > > # > > > # @node: the numa node > > > # > > > -# @size: the size of epc section > > > +# @size: the size of EPC section > > > # > > > -# Since: 6.2 > > > +# Since: 7.0 > > > ## > > > { 'struct': 'SGXEPCSection', > > > 'data': { 'node': 'int', > > > @@ -365,7 +365,7 @@ > > > # > > > # @flc: true if FLC is supported > > > # > > > -# @sections: The EPC sections info for guest > > > +# @sections: The EPC sections info for guest(Since: 7.0) > > > > Minor point - a space is needed before '(' > > > > > # > > > # Since: 6.2 > > > ## > > > @@ -390,7 +390,9 @@ > > > # > > > # -> { "execute": "query-sgx" } > > > # <- { "return": { "sgx": true, "sgx1" : true, "sgx2" : true, > > > -# "flc": true, "section-size" : 0 } } > > > +# "flc": true, "sections": > > > +# [{"node": 0, "size": 67108864}, > > > +# {"node": 1, "size": 29360128}]} } > > > # > > > ## > > > { 'command': 'query-sgx', 'returns': 'SGXInfo', 'if': 'TARGET_I386' } > > > @@ -408,7 +410,9 @@ > > > # > > > # -> { "execute": "query-sgx-capabilities" } > > > # <- { "return": { "sgx": true, "sgx1" : true, "sgx2" : true, > > > -# "flc": true, "section-size" : 0 } } > > > +# "flc": true, "section" : > > > +# [{"node": 0, "size": 67108864}, > > > +# {"node": 1, "size": 29360128}]} } > > > > The 'section-size' shouldn't be removed here - we still need the > > command fixed to bring back the 'section-size' as it should not > > have been deleted. > > > > Adding the 'section' docs is ok though. > > > Thanks Daniel, You mean I need add extra doc like below? 6.2 and 7.0 command > description for @query-sgx ? > > ## > # @query-sgx: > # > # Returns information about SGX > # > # Returns: @SGXInfo > # > # Since: 6.2 > # > # Example: > # > # -> { "execute": "query-sgx" } > # <- { "return": { "sgx": true, "sgx1" : true, "sgx2" : true, > # "flc": true, "section-size" : 0 } } > # > # Since: 7.0 > # > # Example: > # > # -> { "execute": "query-sgx" } > # <- { "return": { "sgx": true, "sgx1" : true, "sgx2" : true, > # "flc": true, "sections": > # [{"node": 0, "size": 67108864}, > # {"node": 1, "size": 29360128}]} } No, I'm saying you need to fix the query-sgx command so that it still reports 'section-size': # Example: # # -> { "execute": "query-sgx" } # <- { "return": { "sgx": true, "sgx1" : true, "sgx2" : true, # "flc": true, "section-size" : 0, # "sections": [ # {"node": 0, "size": 67108864}, # {"node": 1, "size": 29360128}] } } Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|