From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "David Edmondson" <david.edmondson@oracle.com>,
"Kashyap Chamarthy" <kchamart@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] docs: expand firmware descriptor to allow flash without NVRAM
Date: Tue, 25 Jan 2022 15:09:40 +0000 [thread overview]
Message-ID: <YfAStHc/JGDsomC+@redhat.com> (raw)
In-Reply-To: <20220125075054.dnlnr4pliw3bio2k@sirius.home.kraxel.org>
On Tue, Jan 25, 2022 at 08:50:54AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > { 'struct' : 'FirmwareMappingFlash',
> > > - 'data' : { 'executable' : 'FirmwareFlashFile',
> > > - 'nvram-template' : 'FirmwareFlashFile' } }
> > > + 'data' : { 'mode': 'FirmwareFlashMode',
> > > + 'executable' : 'FirmwareFlashFile',
> > > + '*nvram-template' : 'FirmwareFlashFile' } }
>
> I think for backward compatibility reasons we want 'mode' be optional,
> with 'mode' = 'split' being assumed in case it is not present.
>
> otherwise looks sane to me.
Opps, yes, I even documented that it was optional but then failed
to mark it optional.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2022-01-25 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 15:34 [PATCH] docs: expand firmware descriptor to allow flash without NVRAM Daniel P. Berrangé
2022-01-22 9:07 ` Philippe Mathieu-Daudé via
2022-01-25 7:50 ` Gerd Hoffmann
2022-01-25 15:09 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfAStHc/JGDsomC+@redhat.com \
--to=berrange@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=f4bug@amsat.org \
--cc=kchamart@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).