From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AF4AC433F5 for ; Fri, 28 Jan 2022 17:22:30 +0000 (UTC) Received: from localhost ([::1]:60452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDUxB-0006EI-0F for qemu-devel@archiver.kernel.org; Fri, 28 Jan 2022 12:22:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDTfq-0006qB-QQ for qemu-devel@nongnu.org; Fri, 28 Jan 2022 11:00:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:49956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDTfm-0002Yf-8K for qemu-devel@nongnu.org; Fri, 28 Jan 2022 11:00:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643385616; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JFqRJA5jl7VFVg3XxNiptOMojwN4zBEMreCSmuV9gI=; b=TeDPvddgUqdsGeYNadBLdYnFCBa/XXZTn3LR0/0IZk8bCSaQEoPl41nDYksUJSioOQA0Nk Opl5b/yK8iF6v/RXf0ttV/B5MjH17hlRy8M9+ieFKi46sFJooODIfo4E6Bg7wkFK53f723 XuYIcxzw1X491c/u1rHyofNYnqliFac= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-597-s8KuRmksMK2cRBGpKuI38w-1; Fri, 28 Jan 2022 11:00:09 -0500 X-MC-Unique: s8KuRmksMK2cRBGpKuI38w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC7091091DA1; Fri, 28 Jan 2022 16:00:08 +0000 (UTC) Received: from redhat.com (unknown [10.33.37.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6E9084A35; Fri, 28 Jan 2022 16:00:07 +0000 (UTC) Date: Fri, 28 Jan 2022 16:00:05 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Subject: Re: [PATCH v2 1/2] python: introduce qmp-shell-wrap convenience tool Message-ID: References: <20220118100140.252920-1-berrange@redhat.com> <20220118100140.252920-2-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , Cleber Rosa , qemu-devel , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jan 18, 2022 at 08:07:32PM -0500, John Snow wrote: > On Tue, Jan 18, 2022 at 5:01 AM Daniel P. Berrangé wrote: > > > > With the current 'qmp-shell' tool developers must first spawn QEMU with > > a suitable -qmp arg and then spawn qmp-shell in a separate terminal > > pointing to the right socket. > > > > With 'qmp-shell-wrap' developers can ignore QMP sockets entirely and > > just pass the QEMU command and arguments they want. The program will > > listen on a UNIX socket and tell QEMU to connect QMP to that. > > > > For example, this: > > > > # qmp-shell-wrap -- qemu-system-x86_64 -display none > > > > Is roughly equivalent of running: > > > > # qemu-system-x86_64 -display none -qmp qmp-shell-1234 & > > # qmp-shell qmp-shell-1234 > > > > Except that 'qmp-shell-wrap' switches the socket peers around so that > > it is the UNIX socket server and QEMU is the socket client. This makes > > QEMU reliably go away when qmp-shell-wrap exits, closing the server > > socket. > > > > Signed-off-by: Daniel P. Berrangé > > Thanks, I think this is pretty useful. > > Can you look at setup.cfg and see about adding a qmp-shell-wrap entry > point there? I had intended to wean people off of using /scripts for > things that rely on the QMP packages, because I'm gonna fork them out > and then these little forwards won't work without installing something > anyway. > > Also, as an FYI: Stuff that sticks around in /python/qemu/qmp/ is > going to get forked out and uploaded to PyPI; stuff that gets added to > /python/qemu/utils is going to stay local to our tree and has more > freedom to be changed liberally. If you don't think this script > belongs on PyPI, we could always stick it in util. IMHO it belongs anywhere that the existing qmp-shell lives Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|