From: David Gibson <david@gibson.dropbear.id.au>
To: Fabiano Rosas <farosas@linux.ibm.com>
Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, clg@kaod.org
Subject: Re: [PATCH v2 23/27] target/ppc: Rename spr_tcg.h to spr_common.h
Date: Thu, 17 Feb 2022 10:34:23 +1100 [thread overview]
Message-ID: <Yg2J/2fhqOq/aL0Z@yekko> (raw)
In-Reply-To: <20220216162426.1885923-24-farosas@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2546 bytes --]
On Wed, Feb 16, 2022 at 01:24:22PM -0300, Fabiano Rosas wrote:
> Initial intent for the spr_tcg header was to expose the spr_read|write
> callbacks that are only used by TCG code. However, although these
> routines are TCG-specific, the KVM code needs access to env->sprs
> which creation is currently coupled to the callback registration.
>
> We are probably not going to decouple SPR creation and TCG callback
> registration any time soon, so let's rename the header to spr_common
> to accomodate the register_*_sprs functions that will be moved out of
> cpu_init.c in the following patches.
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> target/ppc/cpu_init.c | 2 +-
> target/ppc/{spr_tcg.h => spr_common.h} | 4 ++--
> target/ppc/translate.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
> rename target/ppc/{spr_tcg.h => spr_common.h} (99%)
>
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index adb23019ef..17f12aceb6 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -44,7 +44,7 @@
>
> #include "helper_regs.h"
> #include "internal.h"
> -#include "spr_tcg.h"
> +#include "spr_common.h"
> #include "power8-pmu.h"
>
> /* #define PPC_DEBUG_SPR */
> diff --git a/target/ppc/spr_tcg.h b/target/ppc/spr_common.h
> similarity index 99%
> rename from target/ppc/spr_tcg.h
> rename to target/ppc/spr_common.h
> index df2abacc64..5aec76ade4 100644
> --- a/target/ppc/spr_tcg.h
> +++ b/target/ppc/spr_common.h
> @@ -16,8 +16,8 @@
> * You should have received a copy of the GNU Lesser General Public
> * License along with this library; if not, see <http://www.gnu.org/licenses/>.
> */
> -#ifndef SPR_TCG_H
> -#define SPR_TCG_H
> +#ifndef SPR_COMMON_H
> +#define SPR_COMMON_H
>
> #define SPR_NOACCESS (&spr_noaccess)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 2eaffd432a..ecc5a104e0 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -35,7 +35,7 @@
> #include "exec/translator.h"
> #include "exec/log.h"
> #include "qemu/atomic128.h"
> -#include "spr_tcg.h"
> +#include "spr_common.h"
>
> #include "qemu/qemu-print.h"
> #include "qapi/error.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-17 1:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 16:23 [PATCH v2 00/27] target/ppc: SPR registration cleanups Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 01/27] target/ppc: cpu_init: Remove not implemented comments Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 02/27] target/ppc: cpu_init: Remove G2LE init code Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 03/27] target/ppc: cpu_init: Group registration of generic SPRs Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 04/27] target/ppc: cpu_init: Move Timebase registration into the common function Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 05/27] target/ppc: cpu_init: Avoid nested SPR register functions Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 06/27] target/ppc: cpu_init: Move 405 SPRs into register_405_sprs Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 07/27] target/ppc: cpu_init: Move G2 SPRs into register_G2_sprs Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 08/27] target/ppc: cpu_init: Decouple G2 SPR registration from 755 Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 09/27] target/ppc: cpu_init: Decouple 74xx SPR registration from 7xx Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 10/27] target/ppc: cpu_init: Deduplicate 440 SPR registration Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 11/27] target/ppc: cpu_init: Deduplicate 603 " Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 12/27] target/ppc: cpu_init: Deduplicate 604 " Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 13/27] target/ppc: cpu_init: Deduplicate 745/755 " Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 14/27] target/ppc: cpu_init: Deduplicate 7xx " Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 15/27] target/ppc: cpu_init: Move 755 L2 cache SPRs into a function Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 16/27] target/ppc: cpu_init: Move e300 SPR registration " Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 17/27] target/ppc: cpu_init: Move 604e " Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 18/27] target/ppc: cpu_init: Reuse init_proc_603 for the e300 Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 19/27] target/ppc: cpu_init: Reuse init_proc_604 for the 604e Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 20/27] target/ppc: cpu_init: Reuse init_proc_745 for the 755 Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 21/27] target/ppc: cpu_init: Rename register_ne_601_sprs Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 22/27] target/ppc: cpu_init: Remove register_usprg3_sprs Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 23/27] target/ppc: Rename spr_tcg.h to spr_common.h Fabiano Rosas
2022-02-16 23:34 ` David Gibson [this message]
2022-02-16 16:24 ` [PATCH v2 24/27] target/ppc: cpu_init: Expose some SPR registration helpers Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 25/27] target/ppc: cpu_init: Move SPR registration macros to a header Fabiano Rosas
2022-02-16 16:24 ` [PATCH v2 26/27] target/ppc: cpu_init: Move check_pow and QOM " Fabiano Rosas
2022-02-16 23:35 ` David Gibson
2022-02-16 16:24 ` [PATCH v2 27/27] target/ppc: Move common SPR functions out of cpu_init Fabiano Rosas
2022-02-18 7:42 ` [PATCH v2 00/27] target/ppc: SPR registration cleanups Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg2J/2fhqOq/aL0Z@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=farosas@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).