From: Peter Krempa <pkrempa@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: "Yang Zhong" <yang.zhong@intel.com>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
libvir-list@redhat.com, qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine
Date: Mon, 7 Feb 2022 12:28:47 +0100 [thread overview]
Message-ID: <YgECb9o2EwkUldzz@angien.pipo.sk> (raw)
In-Reply-To: <CAARzgwyjH70AaEZ=DNSARP++KJfAi2wZkpx6uOhpW0jEigf16A@mail.gmail.com>
On Mon, Feb 07, 2022 at 16:50:28 +0530, Ani Sinha wrote:
> On Mon, Feb 7, 2022 at 3:12 PM Peter Krempa <pkrempa@redhat.com> wrote:
> >
> > On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa wrote:
> > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote:
> > > > On Mon, 7 Feb 2022 09:14:37 +0100
> > > > Igor Mammedov <imammedo@redhat.com> wrote:
> >
> > [...]
> >
> > > Even if we change it in libvirt right away, changing qemu will break
> > > forward compatibility. While we don't guarantee it, it still creates
> > > user grief.
> >
> > I've filed an upstream issue:
> >
> > https://gitlab.com/libvirt/libvirt/-/issues/272
>
> I can look into this bug. Feel free to assign it to me.
No need to. I've noticed that we already call query-hotpluggable-cpus
so with a simple modification the VM startup code path can be easily
fixed so I've done so.
next prev parent reply other threads:[~2022-02-07 11:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 12:45 [PATCH v4 0/4] hw/i386: QOM-attach CPUs/SGX-EPC objects to their parents Philippe Mathieu-Daudé via
2022-02-05 12:45 ` [PATCH v4 1/4] tests/qtest/acpi: Temporary allow VIOT table changes Philippe Mathieu-Daudé via
2022-02-05 12:45 ` [PATCH v4 2/4] hw/i386: Attach CPUs to machine Philippe Mathieu-Daudé via
2022-02-07 8:14 ` Igor Mammedov
2022-02-07 9:18 ` Igor Mammedov
2022-02-07 9:36 ` Peter Krempa
2022-02-07 9:41 ` Peter Krempa
2022-02-07 11:20 ` Ani Sinha
2022-02-07 11:28 ` Peter Krempa [this message]
2022-02-07 11:37 ` Ani Sinha
2022-02-07 10:06 ` Daniel P. Berrangé
2022-02-07 11:22 ` Igor Mammedov
2022-02-07 11:48 ` Daniel P. Berrangé
2022-02-07 13:17 ` Igor Mammedov
2022-02-07 13:51 ` Peter Maydell
2022-02-05 12:45 ` [PATCH v4 3/4] tests/qtest/acpi: Update VIOT table blob Philippe Mathieu-Daudé via
2022-02-05 12:45 ` [PATCH v4 4/4] hw/i386/sgx: Attach SGX-EPC objects to machine Philippe Mathieu-Daudé via
2022-02-07 8:37 ` Igor Mammedov
2022-02-07 8:47 ` Philippe Mathieu-Daudé via
2022-02-14 6:58 ` Yang Zhong
2022-02-14 8:21 ` Igor Mammedov
2022-02-14 10:30 ` Daniel P. Berrangé
2022-02-16 9:01 ` Igor Mammedov
2022-02-14 7:27 ` Yang Zhong
2022-02-05 16:24 ` [PATCH v4 0/4] hw/i386: QOM-attach CPUs/SGX-EPC objects to their parents Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgECb9o2EwkUldzz@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=ani@anisinha.ca \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).