From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F8C8C433F5 for ; Mon, 7 Feb 2022 14:19:34 +0000 (UTC) Received: from localhost ([::1]:37076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nH4rd-0007Sh-6U for qemu-devel@archiver.kernel.org; Mon, 07 Feb 2022 09:19:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nH4mV-0008Gh-7k for qemu-devel@nongnu.org; Mon, 07 Feb 2022 09:14:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nH4mN-0003vs-32 for qemu-devel@nongnu.org; Mon, 07 Feb 2022 09:14:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644243246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TmwpFWTkFNZBbY3UMK20A0+Bbsz/QHVsCYz6s1lDXVY=; b=VJ1mAX5pd1IZ0BQ5rqYfbkC4B9ee9lXS76l6p/UkVUYtfGrRbcf3LslBdN45tXmi8O2fjP lqBWYbCksoPz/XAWJ0h/X70psghrcrIOnaaShf1cp8c7dC+5cagFW8W9WWUvOd0uUZZP+v HUgAAGf9CuAC3wguq5f1SUPNzmq/xIc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-167-wc0f0rHOPzuu7qn7l_Omkw-1; Mon, 07 Feb 2022 09:14:04 -0500 X-MC-Unique: wc0f0rHOPzuu7qn7l_Omkw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E075F1091DB7 for ; Mon, 7 Feb 2022 14:14:03 +0000 (UTC) Received: from horse.redhat.com (unknown [10.22.9.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0F742B5AE; Mon, 7 Feb 2022 14:13:53 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 4573D2237EB; Mon, 7 Feb 2022 09:13:53 -0500 (EST) Date: Mon, 7 Feb 2022 09:13:53 -0500 From: Vivek Goyal To: "Dr. David Alan Gilbert" Subject: Re: [PATCH v5 9/9] virtiofsd: Add an option to enable/disable security label Message-ID: References: <20220202193935.268777-1-vgoyal@redhat.com> <20220202193935.268777-10-vgoyal@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, mszeredi@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Feb 07, 2022 at 12:40:21PM +0000, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgoyal@redhat.com) wrote: > > Provide an option "-o security_label/no_security_label" to enable/disable > > security label functionality. By default these are turned off. > > > > If enabled, server will indicate to client that it is capable of handling > > one security label during file creation. Typically this is expected to > > be a SELinux label. File server will set this label on the file. It will > > try to set it atomically wherever possible. But its not possible in > > all the cases. > > > > Signed-off-by: Vivek Goyal > > --- > > docs/tools/virtiofsd.rst | 7 +++++++ > > tools/virtiofsd/helper.c | 1 + > > tools/virtiofsd/passthrough_ll.c | 15 +++++++++++++++ > > 3 files changed, 23 insertions(+) > > > > diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst > > index 07ac0be551..a2c005f4a0 100644 > > --- a/docs/tools/virtiofsd.rst > > +++ b/docs/tools/virtiofsd.rst > > @@ -104,6 +104,13 @@ Options > > * posix_acl|no_posix_acl - > > Enable/disable posix acl support. Posix ACLs are disabled by default. > > > > + * security_label|no_security_label - > > + Enable/disable security label support. Security labels are disabled by > > + default. This will allow client to send a MAC label of file during > ^ the ^ a > > + file creation. Typically this is expected to be SELinux security > ^ an > > > + label. Server will try to set that label on newly created file > ^The server > > + atomically wherever possible. > > + > > .. option:: --socket-path=PATH > > > > Listen on vhost-user UNIX domain socket at PATH. > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > > index a8295d975a..e226fc590f 100644 > > --- a/tools/virtiofsd/helper.c > > +++ b/tools/virtiofsd/helper.c > > @@ -187,6 +187,7 @@ void fuse_cmdline_help(void) > > " default: no_allow_direct_io\n" > > " -o announce_submounts Announce sub-mount points to the guest\n" > > " -o posix_acl/no_posix_acl Enable/Disable posix_acl. (default: disabled)\n" > > + " -o security_label/no_security_label Enable/Disable security label. (default: disabled)\n" > > ); > > } > > > > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c > > index 43c9b6dbe5..fe8f3ccbb6 100644 > > --- a/tools/virtiofsd/passthrough_ll.c > > +++ b/tools/virtiofsd/passthrough_ll.c > > @@ -181,6 +181,7 @@ struct lo_data { > > int user_posix_acl, posix_acl; > > /* Keeps track if /proc//attr/fscreate should be used or not */ > > bool use_fscreate; > > + int user_security_label; > > }; > > > > static const struct fuse_opt lo_opts[] = { > > @@ -215,6 +216,8 @@ static const struct fuse_opt lo_opts[] = { > > { "no_killpriv_v2", offsetof(struct lo_data, user_killpriv_v2), 0 }, > > { "posix_acl", offsetof(struct lo_data, user_posix_acl), 1 }, > > { "no_posix_acl", offsetof(struct lo_data, user_posix_acl), 0 }, > > + { "security_label", offsetof(struct lo_data, user_security_label), 1 }, > > + { "no_security_label", offsetof(struct lo_data, user_security_label), 0 }, > > FUSE_OPT_END > > }; > > static bool use_syslog = false; > > @@ -771,6 +774,17 @@ static void lo_init(void *userdata, struct fuse_conn_info *conn) > > fuse_log(FUSE_LOG_DEBUG, "lo_init: disabling posix_acl\n"); > > conn->want &= ~FUSE_CAP_POSIX_ACL; > > } > > + > > + if (lo->user_security_label == 1) { > > + if (!(conn->capable & FUSE_CAP_SECURITY_CTX)) { > > + fuse_log(FUSE_LOG_ERR, "lo_init: Can not enable security label." > > + " kernel does not support FUSE_SECURITY_CTX capability.\n"); > > + } > > Do you need to exit in this case - or at least clear the flag? Actually we don't have to necessarily exit here because fuse_lowlevel.c has a check which makes it exit. And that's why I do not clear the flag from ->want to signifiy that filesystem wants that capability but client is not ->capable so error out and exit. if (se->conn.want & (~se->conn.capable)) { fuse_log(FUSE_LOG_ERR, "fuse: error: filesystem requested capabilities " "0x%llx that are not supported by kernel, aborting.\n", se->conn.want & (~se->conn.capable)); fuse_reply_err(req, EPROTO); se->error = -EPROTO; fuse_session_exit(se); return; } Thanks Vivek > > Dave > > > + conn->want |= FUSE_CAP_SECURITY_CTX; > > + } else { > > + fuse_log(FUSE_LOG_DEBUG, "lo_init: disabling security label\n"); > > + conn->want &= ~FUSE_CAP_SECURITY_CTX; > > + } > > } > > > > static void lo_getattr(fuse_req_t req, fuse_ino_t ino, > > @@ -4279,6 +4293,7 @@ int main(int argc, char *argv[]) > > .proc_self_task = -1, > > .user_killpriv_v2 = -1, > > .user_posix_acl = -1, > > + .user_security_label = -1, > > }; > > struct lo_map_elem *root_elem; > > struct lo_map_elem *reserve_elem; > > -- > > 2.34.1 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK >