From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6940BC433F5 for ; Mon, 7 Feb 2022 18:05:09 +0000 (UTC) Received: from localhost ([::1]:52648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nH8Nw-0004ff-BG for qemu-devel@archiver.kernel.org; Mon, 07 Feb 2022 13:05:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nH7xD-0003jT-1G for qemu-devel@nongnu.org; Mon, 07 Feb 2022 12:37:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nH7x0-0008GY-LF for qemu-devel@nongnu.org; Mon, 07 Feb 2022 12:37:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644255438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3pFd9HQxvUOhpvOGbZQQjedYuUuO3lTd/qsLT7WDzT8=; b=b28ZZqcJ2VaAD1YV6QGAXtThxScMJ5IzGpGCl+KK58nxOqC+6T6TZx+EUyxCgEcsrt/5Kp MNZJlaKcwRJcbwPET5v3sUlue5sTGPz/mHJ6NTKhf3BTb3Ot9lj5mrJLelQUzKa+4EZUeJ XgYgfDhgwbMcPi/bdfYixHVJg+PJoDA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-394-QLzbQJguPmOgVNjmJE472g-1; Mon, 07 Feb 2022 12:37:15 -0500 X-MC-Unique: QLzbQJguPmOgVNjmJE472g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FE6B1006AAB; Mon, 7 Feb 2022 17:37:13 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B6F37745F; Mon, 7 Feb 2022 17:36:14 +0000 (UTC) Date: Mon, 7 Feb 2022 18:36:13 +0100 From: Kevin Wolf To: Emanuele Giuseppe Esposito Subject: Re: [PATCH v6 22/33] block/coroutines: I/O API Message-ID: References: <20220121170544.2049944-1-eesposit@redhat.com> <20220121170544.2049944-23-eesposit@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220121170544.2049944-23-eesposit@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , qemu-devel@nongnu.org, "Denis V. Lunev" , Eric Blake , qemu-block@nongnu.org, Juan Quintela , Daniel Henrique Barboza , Markus Armbruster , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , =?iso-8859-1?Q?C=E9dric?= Le Goater , Stefan Hajnoczi , John Snow , David Gibson , Eduardo Habkost , Vladimir Sementsov-Ogievskiy , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Hanna Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: > block coroutines functions run in different aiocontext, and are > not protected by the BQL. Therefore are I/O. > > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Paolo Bonzini > Reviewed-by: Stefan Hajnoczi > --- > block/coroutines.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/block/coroutines.h b/block/coroutines.h > index c8c14a29c8..c61abd271a 100644 > --- a/block/coroutines.h > +++ b/block/coroutines.h > @@ -29,6 +29,12 @@ > > /* For blk_bs() in generated block/block-gen.c */ > #include "sysemu/block-backend.h" > +/* > + * I/O API functions. These functions are thread-safe. > + * > + * See include/block/block-io.h for more information about > + * the I/O API. > + */ Please keep an empty line between #include and the rest. As discussed in patch 2, this file will need some rearrangement. Generally, the coroutine_fn is indeed I/O, but the generated_co_wrapper is mixed "I/O or GS" and requires the BQL or a specific iothread. Kevin