From: Stafford Horne <shorne@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: QEMU Development <qemu-devel@nongnu.org>, Jia Liu <proljc@gmail.com>
Subject: Re: [PATCH 2/4] hw/openrisc/openrisc_sim: Paramatarize initialization
Date: Thu, 10 Feb 2022 21:18:05 +0900 [thread overview]
Message-ID: <YgUCfWa1xCRLIc8Z@antec> (raw)
In-Reply-To: <ac0eb0a2-8a8e-c95c-08a4-4dfe07862f9b@amsat.org>
On Thu, Feb 10, 2022 at 12:07:02PM +0100, Philippe Mathieu-Daudé wrote:
> On 10/2/22 07:30, Stafford Horne wrote:
> > Move magic numbers to variables and enums. These will be
> > reused for upcoming fdt initialization.
> >
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> > hw/openrisc/openrisc_sim.c | 42 ++++++++++++++++++++++++++++++--------
> > 1 file changed, 34 insertions(+), 8 deletions(-)
>
> Typo "Parameterize" in subject.
Yes.
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thank you.
next prev parent reply other threads:[~2022-02-10 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 6:30 [PATCH 0/4] OpenRISC Device Tree Support Stafford Horne
2022-02-10 6:30 ` [PATCH 1/4] hw/openrisc/openrisc_sim: Create machine state for or1ksim Stafford Horne
2022-02-10 11:05 ` Philippe Mathieu-Daudé via
2022-02-10 12:16 ` Stafford Horne
2022-02-10 6:30 ` [PATCH 2/4] hw/openrisc/openrisc_sim: Paramatarize initialization Stafford Horne
2022-02-10 11:07 ` Philippe Mathieu-Daudé via
2022-02-10 12:18 ` Stafford Horne [this message]
2022-02-10 6:30 ` [PATCH 3/4] hw/openrisc/openrisc_sim; Add support for loading a decice tree Stafford Horne
2022-02-10 11:10 ` Philippe Mathieu-Daudé via
2022-02-10 12:34 ` Stafford Horne
2022-02-17 18:18 ` Peter Maydell
2022-02-17 21:39 ` Stafford Horne
2022-02-18 11:46 ` Peter Maydell
2022-02-10 6:30 ` [PATCH 4/4] hw/openrisc/openrisc_sim: Add support for initrd loading Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgUCfWa1xCRLIc8Z@antec \
--to=shorne@gmail.com \
--cc=f4bug@amsat.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).