qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: fam@euphon.net, Thomas Huth <thuth@redhat.com>,
	Beraldo Leal <bleal@redhat.com>,
	qemu-devel@nongnu.org,
	Wainer dos Santos Moschetta <wainersm@redhat.com>,
	f4bug@amsat.org, qemu-arm@nongnu.org, stefanha@redhat.com,
	crosa@redhat.com, pbonzini@redhat.com, aurelien@aurel32.net
Subject: Re: [PATCH  v1 02/11] tests/docker: add NOUSER for alpine image
Date: Fri, 11 Feb 2022 16:23:03 +0000	[thread overview]
Message-ID: <YgaNZyojexpreBWj@redhat.com> (raw)
In-Reply-To: <20220211160309.335014-3-alex.bennee@linaro.org>

On Fri, Feb 11, 2022 at 04:03:00PM +0000, Alex Bennée wrote:
> The alpine image doesn't have a standard useradd binary so disable
> this convenience feature for it.

Hmm, can you elaborate on the problem here ?

IIUC, the NOUSER env was just about controlling what docker
flags we added. I didn't know it had a dependancy on stuff
inside the image ?

> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/docker/Makefile.include | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 0ec59b2193..286f0ac5b5 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -158,6 +158,9 @@ docker-image-debian-native: DOCKER_REGISTRY=
>  docker-image-debian10: NOUSER=1
>  docker-image-debian11: NOUSER=1
>  
> +# alpine has no adduser
> +docker-image-alpine: NOUSER=1
> +
>  #
>  # The build rule for hexagon-cross is special in so far for most of
>  # the time we don't want to build it. While dockers caching does avoid
> -- 
> 2.30.2
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2022-02-11 16:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 16:02 [PATCH v1 00/11] testing/next (docker, lcitool, ci, tcg) Alex Bennée
2022-02-11 16:02 ` [PATCH v1 01/11] tests/docker: restore TESTS/IMAGES filtering Alex Bennée
2022-02-11 16:03 ` [PATCH v1 02/11] tests/docker: add NOUSER for alpine image Alex Bennée
2022-02-11 16:23   ` Daniel P. Berrangé [this message]
2022-02-11 17:51     ` Alex Bennée
2022-02-11 18:08       ` Daniel P. Berrangé
2022-02-11 16:03 ` [PATCH v1 03/11] tests/lcitool: update to latest version Alex Bennée
2022-02-11 16:03 ` [PATCH v1 04/11] tests/docker: update debian-arm64-cross with lci-tool Alex Bennée
2022-02-11 21:08   ` Richard Henderson
2022-02-11 16:03 ` [PATCH v1 05/11] tests/docker: introduce debian-riscv64-test-cross Alex Bennée
2022-02-11 21:09   ` Richard Henderson
2022-02-11 16:03 ` [PATCH v1 06/11] scripts/ci: add build env rules for aarch32 on aarch64 Alex Bennée
2022-02-11 16:03 ` [PATCH v1 07/11] scripts/ci: allow for a secondary runner Alex Bennée
2022-02-11 16:03 ` [PATCH v1 08/11] gitlab: add a new aarch32 custom runner definition Alex Bennée
2022-02-11 16:03 ` [PATCH v1 09/11] tests/tcg: build sha1-vector with O3 and compare Alex Bennée
2022-02-11 21:50   ` Richard Henderson
2022-02-11 16:03 ` [PATCH v1 10/11] tests/tcg: add sha512 test Alex Bennée
2022-02-11 16:03 ` [PATCH v1 11/11] tests/tcg: add vectorised sha512 versions Alex Bennée
2022-02-14 14:17   ` Matheus K. Ferst
2022-02-14 15:14     ` Alex Bennée
2022-02-17 12:46       ` Matheus K. Ferst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgaNZyojexpreBWj@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).