From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA78DC433EF for ; Fri, 11 Feb 2022 17:34:16 +0000 (UTC) Received: from localhost ([::1]:48448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIZoE-0006AT-Iw for qemu-devel@archiver.kernel.org; Fri, 11 Feb 2022 12:34:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIZmQ-0005HP-ED for qemu-devel@nongnu.org; Fri, 11 Feb 2022 12:32:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIZmM-0002V1-OX for qemu-devel@nongnu.org; Fri, 11 Feb 2022 12:32:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644600737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CjEu1mqhBNEeoWuGN67Q6AjOOmeuJ3lBTz8oQNuR7MY=; b=E2sf/1wyLXf8SEDLmbOFplFW02WPm4ett+/XFef2dVyWCx4KBF01BHJaq6gRzko5eh+G9C N090WkSo1RgxUcLbR8aSviIDfTjkZQwqMIVzF64vHhRpjWLmBfg44ePkPR8QCtWOYysRnp ADMetOXJxd1hU1Z/pVH/maURcGEfwao= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-moshSKV2OYiiy_xLWJwzPA-1; Fri, 11 Feb 2022 12:32:16 -0500 X-MC-Unique: moshSKV2OYiiy_xLWJwzPA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4FC88180E49C; Fri, 11 Feb 2022 17:32:15 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98B0C838E9; Fri, 11 Feb 2022 17:32:13 +0000 (UTC) Date: Fri, 11 Feb 2022 18:32:11 +0100 From: Kevin Wolf To: Hanna Reitz Subject: Re: [PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations Message-ID: References: <20220209101530.3442837-1-thuth@redhat.com> <20220209101530.3442837-2-thuth@redhat.com> <362412d7-4676-1733-fef6-825fda8e34a0@redhat.com> <66487f51-1fdd-3a49-bc6f-b89ab3d2e54c@redhat.com> MIME-Version: 1.0 In-Reply-To: <66487f51-1fdd-3a49-bc6f-b89ab3d2e54c@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Thomas Huth , qemu-devel@nongnu.org, qemu-block@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 11.02.2022 um 17:14 hat Hanna Reitz geschrieben: > On 11.02.22 17:00, Kevin Wolf wrote: > > Am 11.02.2022 um 14:53 hat Thomas Huth geschrieben: > > > On 11/02/2022 10.29, Kevin Wolf wrote: > > > > Am 09.02.2022 um 11:15 hat Thomas Huth geschrieben: > > > > > If multiple tests run in parallel, they must use unique file > > > > > names for the test output. > > > > > > > > > > Suggested-by: Hanna Reitz > > > > > Signed-off-by: Thomas Huth > > > > > --- > > > > > tests/qemu-iotests/testrunner.py | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py > > > > > index 0eace147b8..9d20f51bb1 100644 > > > > > --- a/tests/qemu-iotests/testrunner.py > > > > > +++ b/tests/qemu-iotests/testrunner.py > > > > > @@ -259,7 +259,7 @@ def do_run_test(self, test: str, mp: bool) -> TestResult: > > > > > """ > > > > > f_test = Path(test) > > > > > - f_bad = Path(f_test.name + '.out.bad') > > > > > + f_bad = Path(f'{os.getpid()}-{f_test.name}.out.bad') > > > > > f_notrun = Path(f_test.name + '.notrun') > > > > > f_casenotrun = Path(f_test.name + '.casenotrun') > > > > > f_reference = Path(self.find_reference(test)) > > > > Hmm... It does make sense, but nobody ever cleans those files up. > > > > Currently, the next run of the test will just overwrite the existing > > > > file or delete it when the test succeeds. So after running the test > > > > suite, you have .out.bad files for every failed test, but not for those > > > > that succeeded. > > > > > > > > After this change, won't the test directory accumulate tons of .out.bad > > > > files over time? > > > True ... but we certainly want to keep the file for failed tests for further > > > analysis instead of immediately deleting them ... maybe it would be enough > > > to encode the image format (qcow2, qed, vmdk, ...) into the output name, > > > instead of using the PID, so that "make check SPEED=thorough" works as > > > expected here? > > It depends on what the supported use case for test suites running in > > parallel is. If it's just for testing multiple formats at the same time, > > then this would work, yes. > > > > I could think of more test runs that you might want to do in parallel, > > like different protocols, different image format options, maybe even > > different host file system. I'm not sure if all (or any) of these are > > relevant, though. > > > > Supporting only things that "make check" uses might be a good > > compromise. > > Personally and originally, I wrote that diff to allow me to actually run the > very same test many times in parallel.  If an error occurs only very rarely, > then I like running like 24 loops of the same test with exactly the same > configuration (just different TEST_DIRs, of course) in parallel. > > The fact that the .out.bad files tend to accumulate is why I haven’t sent it > upstream so far.  Personally, I like Vladimir’s idea to put them into > TEST_DIR, but probably just because this works so well for my usual case > where TEST_DIR is on tmpfs and I thus don’t have to clean it up. I think it could actually work fine because if you don't override TEST_DIR, it's the same every time, and then you get the old behaviour, just with the .out.bad files moved into scratch/. Kevin