From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44885C433F5 for ; Wed, 2 Mar 2022 18:36:08 +0000 (UTC) Received: from localhost ([::1]:53756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPTpX-0003YT-8N for qemu-devel@archiver.kernel.org; Wed, 02 Mar 2022 13:36:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPThI-0004uc-Py for qemu-devel@nongnu.org; Wed, 02 Mar 2022 13:27:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPThF-0007vq-Q8 for qemu-devel@nongnu.org; Wed, 02 Mar 2022 13:27:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646245653; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCY+S+PoxaMOSTKIuJlTMs0umdpj+rKF0gwUYA/KOUc=; b=TZbtoKVTMadjrxcgixAyfNnBG0RhBRbs0Kg2EY+mFavvRGMRYQmp2Y9sB+1ZENG6oY04Y9 QR0aOjIOnFVhNlWQgxeFNFA18H4+1NgMCgm/FZF0zjPd/hYj/k85/JFRIjYAZYylykcysu 8fODRDp2t7OLI4ASDhqfNwycKQDdmOw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-543-ToUOWU_mN1i4XTTHcKclOQ-1; Wed, 02 Mar 2022 13:27:30 -0500 X-MC-Unique: ToUOWU_mN1i4XTTHcKclOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C63E51091DA1; Wed, 2 Mar 2022 18:27:27 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45DD66ABAF; Wed, 2 Mar 2022 18:26:34 +0000 (UTC) Date: Wed, 2 Mar 2022 18:26:31 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Subject: Re: [PATCH 2/2] Allow building vhost-user in BSD Message-ID: References: <20220302113644.43717-1-slp@redhat.com> <20220302113644.43717-3-slp@redhat.com> <66b68bcc-8d7e-a5f7-5e6c-b2d20c26ab01@redhat.com> <8dfc9854-4d59-0759-88d0-d502ae7c552f@gmail.com> <20220302173009.26auqvy4t4rx74td@mhamilton> <85ed0856-308a-7774-a751-b20588f3d9cd@gmail.com> <2976a926-9dbf-d955-166f-5677a06d9873@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2976a926-9dbf-d955-166f-5677a06d9873@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Fam Zheng , Elena Ufimtseva , kvm@vger.kernel.org, John G Johnson , David Hildenbrand , Eric Farman , Jagannathan Raman , Matthew Rosato , qemu-block@nongnu.org, "Michael S. Tsirkin" , Alex Williamson , Halil Pasic , Christian Borntraeger , vgoyal@redhat.com, Thomas Huth , Sergio Lopez , Richard Henderson , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Stefan Hajnoczi , Kevin Wolf , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Hanna Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 02, 2022 at 07:05:32PM +0100, Paolo Bonzini wrote: > On 3/2/22 18:38, Philippe Mathieu-Daudé wrote: > > On 2/3/22 18:31, Sergio Lopez wrote: > > > On Wed, Mar 02, 2022 at 06:18:59PM +0100, Philippe Mathieu-Daudé wrote: > > > > On 2/3/22 18:10, Paolo Bonzini wrote: > > > > > On 3/2/22 12:36, Sergio Lopez wrote: > > > > > > With the possibility of using pipefd as a replacement on operating > > > > > > systems that doesn't support eventfd, vhost-user can also work on BSD > > > > > > systems. > > > > > > > > > > > > This change allows enabling vhost-user on BSD platforms too and > > > > > > makes libvhost_user (which still depends on eventfd) a linux-only > > > > > > feature. > > > > > > > > > > > > Signed-off-by: Sergio Lopez > > > > > > > > > > I would just check for !windows. > > > > > > > > What about Darwin / Haiku / Illumnos? > > > > > > It should work on every system providing pipe() or pipe2(), so I guess > > > Paolo's right, every platform except Windows. FWIW, I already tested > > > it with Darwin. > > > > Wow, nice. > > > > So maybe simply check for pipe/pipe2 rather than !windows? > > What you really need is not pipes, but AF_UNIX. Recent Windows has AF_UNIX so don't check for that ! What you really need is AF_UNIX and FD passing and pipes and probably more POSIX only features ... Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|