* [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution
@ 2022-02-21 10:19 Thomas Huth
2022-02-21 10:58 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2022-02-21 10:19 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Eric Farman, Daniel P . Berrange, Beraldo Leal,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
Halil Pasic, qemu-s390x, Cleber Rosa, Christian Borntraeger
QEMU's default screen resolution recently changed to 1280x800, so the
resolution in the screen shot header changed of course, too.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/avocado/machine_s390_ccw_virtio.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/avocado/machine_s390_ccw_virtio.py b/tests/avocado/machine_s390_ccw_virtio.py
index bd03d7160b..438a6f4321 100644
--- a/tests/avocado/machine_s390_ccw_virtio.py
+++ b/tests/avocado/machine_s390_ccw_virtio.py
@@ -248,7 +248,7 @@ def test_s390x_fedora(self):
line = ppmfile.readline()
self.assertEqual(line, b"P6\n")
line = ppmfile.readline()
- self.assertEqual(line, b"1024 768\n")
+ self.assertEqual(line, b"1280 800\n")
line = ppmfile.readline()
self.assertEqual(line, b"255\n")
line = ppmfile.readline(256)
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution
2022-02-21 10:19 [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution Thomas Huth
@ 2022-02-21 10:58 ` Daniel P. Berrangé
2022-02-21 12:11 ` Philippe Mathieu-Daudé
2022-02-21 12:26 ` Halil Pasic
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2022-02-21 10:58 UTC (permalink / raw)
To: Thomas Huth
Cc: Peter Maydell, Eric Farman, Beraldo Leal, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé,
Halil Pasic, qemu-s390x, Cleber Rosa, Christian Borntraeger
On Mon, Feb 21, 2022 at 11:19:33AM +0100, Thomas Huth wrote:
> QEMU's default screen resolution recently changed to 1280x800, so the
> resolution in the screen shot header changed of course, too.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/avocado/machine_s390_ccw_virtio.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution
2022-02-21 10:19 [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution Thomas Huth
2022-02-21 10:58 ` Daniel P. Berrangé
@ 2022-02-21 12:11 ` Philippe Mathieu-Daudé
2022-02-21 12:26 ` Halil Pasic
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-02-21 12:11 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Peter Maydell
Cc: Eric Farman, Daniel P . Berrange, Beraldo Leal,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
Halil Pasic, qemu-s390x, Cleber Rosa, Christian Borntraeger
On 21/2/22 11:19, Thomas Huth wrote:
> QEMU's default screen resolution recently changed to 1280x800, so the
> resolution in the screen shot header changed of course, too.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/avocado/machine_s390_ccw_virtio.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution
2022-02-21 10:19 [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution Thomas Huth
2022-02-21 10:58 ` Daniel P. Berrangé
2022-02-21 12:11 ` Philippe Mathieu-Daudé
@ 2022-02-21 12:26 ` Halil Pasic
2 siblings, 0 replies; 4+ messages in thread
From: Halil Pasic @ 2022-02-21 12:26 UTC (permalink / raw)
To: Thomas Huth
Cc: Peter Maydell, Eric Farman, Daniel P . Berrange, Beraldo Leal,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
qemu-devel, Halil Pasic, qemu-s390x, Cleber Rosa,
Christian Borntraeger
On Mon, 21 Feb 2022 11:19:33 +0100
Thomas Huth <thuth@redhat.com> wrote:
> QEMU's default screen resolution recently changed to 1280x800, so the
> resolution in the screen shot header changed of course, too.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Looks good!
Acked-by: Halil Pasic <pasic@linux.ibm.com>
> ---
> tests/avocado/machine_s390_ccw_virtio.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/avocado/machine_s390_ccw_virtio.py b/tests/avocado/machine_s390_ccw_virtio.py
> index bd03d7160b..438a6f4321 100644
> --- a/tests/avocado/machine_s390_ccw_virtio.py
> +++ b/tests/avocado/machine_s390_ccw_virtio.py
> @@ -248,7 +248,7 @@ def test_s390x_fedora(self):
> line = ppmfile.readline()
> self.assertEqual(line, b"P6\n")
> line = ppmfile.readline()
> - self.assertEqual(line, b"1024 768\n")
> + self.assertEqual(line, b"1280 800\n")
> line = ppmfile.readline()
> self.assertEqual(line, b"255\n")
> line = ppmfile.readline(256)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-21 13:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-21 10:19 [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution Thomas Huth
2022-02-21 10:58 ` Daniel P. Berrangé
2022-02-21 12:11 ` Philippe Mathieu-Daudé
2022-02-21 12:26 ` Halil Pasic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).