qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] qapi: fix mistake in example command illustration
Date: Wed, 23 Feb 2022 18:37:27 +0000	[thread overview]
Message-ID: <YhZ+562Zrz5NNgiK@work-vm> (raw)
In-Reply-To: <20220223180418.2098303-1-berrange@redhat.com>

* Daniel P. Berrangé (berrange@redhat.com) wrote:
> The snapshot-load/save/delete commands illustrated their usage, but
> mistakenly used 'data' rather than 'arguments' as the field name.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Fabian Holler's patch from yesterday beat you to it slightly;
I think Markus has it queued.

(20220222170116.63105-1-fabian.holler@simplesurance.de )
> ---
>  qapi/migration.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 5975a0e104..1c6296897d 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1888,7 +1888,7 @@
>  # Example:
>  #
>  # -> { "execute": "snapshot-save",
> -#      "data": {
> +#      "arguments": {
>  #         "job-id": "snapsave0",
>  #         "tag": "my-snap",
>  #         "vmstate": "disk0",
> @@ -1949,7 +1949,7 @@
>  # Example:
>  #
>  # -> { "execute": "snapshot-load",
> -#      "data": {
> +#      "arguments": {
>  #         "job-id": "snapload0",
>  #         "tag": "my-snap",
>  #         "vmstate": "disk0",
> @@ -2002,7 +2002,7 @@
>  # Example:
>  #
>  # -> { "execute": "snapshot-delete",
> -#      "data": {
> +#      "arguments": {
>  #         "job-id": "snapdelete0",
>  #         "tag": "my-snap",
>  #         "devices": ["disk0", "disk1"]
> -- 
> 2.34.1
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2022-02-23 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 18:04 [PATCH] qapi: fix mistake in example command illustration Daniel P. Berrangé
2022-02-23 18:37 ` Dr. David Alan Gilbert [this message]
2022-02-24  6:39   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhZ+562Zrz5NNgiK@work-vm \
    --to=dgilbert@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).