From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48281C433EF for ; Wed, 23 Feb 2022 15:46:17 +0000 (UTC) Received: from localhost ([::1]:38990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMtqH-0004Wf-I2 for qemu-devel@archiver.kernel.org; Wed, 23 Feb 2022 10:46:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMtpC-0003kM-Kc for qemu-devel@nongnu.org; Wed, 23 Feb 2022 10:45:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:36023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMtp9-0000di-9U for qemu-devel@nongnu.org; Wed, 23 Feb 2022 10:45:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645631101; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3mcU1dexf4fFxrnA+vUxz/3NwFAGakXfMGeEwuKmv0E=; b=SNxA+giCPDhVMc41sQjaYrTsHQV8IpmrIGJMZ1PgFEZIibUQjbvk9W7MRfLEZeN5uMYNA1 Zxlcwey9LX0+TzNqsMfRHf7klV45LQcFlTlIj7q4xybT+kqDdcBfyLOAj7kG3w9G1ORBjv DVxxIgMp73/HKlsvrf5l9Owc+fI+Wxc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-dYcj_2IZNU6Vrx3me5PRhQ-1; Wed, 23 Feb 2022 10:44:55 -0500 X-MC-Unique: dYcj_2IZNU6Vrx3me5PRhQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 14E161854E27; Wed, 23 Feb 2022 15:44:54 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B84C8276B; Wed, 23 Feb 2022 15:44:52 +0000 (UTC) Date: Wed, 23 Feb 2022 15:44:48 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Subject: Re: [PATCH 4/5] python: qmp_shell: add -e/--exit-on-error option Message-ID: References: <20220221155519.2367-1-damien.hedde@greensocs.com> <20220221155519.2367-5-damien.hedde@greensocs.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Damien Hedde , Eduardo Habkost , qemu-devel , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Feb 23, 2022 at 10:41:11AM -0500, John Snow wrote: > On Wed, Feb 23, 2022 at 10:27 AM Daniel P. Berrangé wrote: > > > > On Wed, Feb 23, 2022 at 10:22:11AM -0500, John Snow wrote: > > > On Mon, Feb 21, 2022 at 10:55 AM Damien Hedde > > > wrote: > > > > > > > > This option makes qmp_shell exit (with error code 1) > > > > as soon as one of the following error occurs: > > > > + command parsing error > > > > + disconnection > > > > + command failure (response is an error) > > > > > > > > _execute_cmd() method now returns None or the response > > > > so that read_exec_command() can do the last check. > > > > > > > > This is meant to be used in combination with an input file > > > > redirection. It allows to store a list of commands > > > > into a file and try to run them by qmp_shell and easily > > > > see if it failed or not. > > > > > > > > Signed-off-by: Damien Hedde > > > > > > Based on this patch, it looks like you really want something > > > scriptable, so I think the qemu-send idea that Dan has suggested might > > > be the best way to go. Are you still hoping to use the interactive > > > "short" QMP command format? That might be a bad idea, given how flaky > > > the parsing is -- and how we don't actually have a published standard > > > for that format. We've *never* liked the bad parsing here, so I have a > > > reluctance to use it in more places. > > > > > > I'm having the naive idea that a script file could be as simple as a > > > list of QMP commands to send: > > > > > > [ > > > {"execute": "block-dirty-bitmap-add", "arguments": { ... }}, > > > ... > > > ] > > > > I'd really recommend against creating a new format for the script > > file, especially one needing opening & closing [] like this, as > > that isn't so amenable to dynamic usage/creation. ie you can't > > just append an extcra command to an existing file. > > > > IMHO, the "file" format should be identical to the result of > > capturing the socket data off the wire. ie just a concatenation > > of QMP commands, with no extra wrapping / change in format. > > > > Eugh. That's just so hard to parse, because there's no off-the-shelf > tooling for "load a sequence of JSON documents". Nothing in Python > does it. :\ It isn't that hard if you require each JSON doc to be followed by a newline. Feed one line at a time to the JSON parser, until you get a complete JSON doc, process that, then re-init the parser and carry on feeding it lines until it emits the next JSON doc, and so on. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|