From: Kashyap Chamarthy <kchamart@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Daniel Berrange <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] scripts/qmp-shell-wrap: Fix import path
Date: Fri, 25 Feb 2022 18:41:49 +0100 [thread overview]
Message-ID: <YhkU3ViX30GRjfHZ@paraplu> (raw)
In-Reply-To: <20220225170828.3418305-1-jsnow@redhat.com>
On Fri, Feb 25, 2022 at 12:08:28PM -0500, John Snow wrote:
> Mea culpa. Dan's patch wound up with the wrong import path because I
> re-ordered my most recent pull request and missed that this needed a fix
> on rebase.
>
> Fixes: 43912529
> Reported-by: Kashyap Chamarthy <kchamart@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qmp/qmp-shell-wrap | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qmp/qmp-shell-wrap b/scripts/qmp/qmp-shell-wrap
> index 9e94da114f..66846e36d1 100755
> --- a/scripts/qmp/qmp-shell-wrap
> +++ b/scripts/qmp/qmp-shell-wrap
> @@ -4,7 +4,7 @@ import os
> import sys
>
> sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
> -from qemu.qmp import qmp_shell
> +from qemu.aqmp import qmp_shell
>
>
> if __name__ == '__main__':
Works for me; thank you.
Tested-by: Kashyap Chamarthy <kchamart@redhat.com>
> --
> 2.34.1
>
--
/kashyap
prev parent reply other threads:[~2022-02-25 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 17:08 [PATCH] scripts/qmp-shell-wrap: Fix import path John Snow
2022-02-25 17:41 ` Kashyap Chamarthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhkU3ViX30GRjfHZ@paraplu \
--to=kchamart@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).