qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Development <qemu-devel@nongnu.org>
Subject: Re: [PULL 0/6] OpenRISC DTS Generation patches for 7.0
Date: Sat, 26 Feb 2022 10:22:11 +0900	[thread overview]
Message-ID: <YhmAwx67OUmPFQ5F@antec> (raw)
In-Reply-To: <CAFEAcA-YSBDpS5+nfJxqAJ6fjHheLO=jOnH=+WFXsDPo6Y=J=g@mail.gmail.com>

On Fri, Feb 25, 2022 at 01:52:52PM +0000, Peter Maydell wrote:
> On Fri, 25 Feb 2022 at 09:19, Stafford Horne <shorne@gmail.com> wrote:
> >
> > The following changes since commit 4aa2e497a98bafe962e72997f67a369e4b52d9c1:
> >
> >   Merge remote-tracking branch 'remotes/berrange-gitlab/tags/misc-next-pull-request' into staging (2022-02-23 09:25:05 +0000)
> >
> > are available in the Git repository at:
> >
> >   git://github.com/stffrdhrn/qemu.git tags/or1k-pull-request
> >
> > for you to fetch changes up to 94c71f14e9ca15ede4172e0826d690b15069a7f8:
> >
> >   hw/openrisc/openrisc_sim: Add support for initrd loading (2022-02-25 15:42:23 +0900)
> >
> > ----------------------------------------------------------------
> > OpenRISC patches
> >
> >  - Add automatic DTS generation to openrisc_sim
> >
> > ----------------------------------------------------------------
> > Stafford Horne (6):
> >       hw/openrisc/openrisc_sim: Create machine state for or1ksim
> >       hw/openrisc/openrisc_sim: Parameterize initialization
> >       hw/openrisc/openrisc_sim: Use IRQ splitter when connecting UART
> >       hw/openrisc/openrisc_sim: Increase max_cpus to 4
> >       hw/openrisc/openrisc_sim: Add automatic device tree generation
> >       hw/openrisc/openrisc_sim: Add support for initrd loading
> 
> Hi; this fails to build on various CI configs, eg:
> https://gitlab.com/qemu-project/qemu/-/jobs/2137393314
> https://gitlab.com/qemu-project/qemu/-/jobs/2137393335
> 
> ../hw/openrisc/openrisc_sim.c:40:10: fatal error: libfdt.h: No such
> file or directory
> 40 | #include <libfdt.h>
> | ^~~~~~~~~~
> 
> 
> This happens because meson doesn't put the include path for libfdt
> on the include path for every .c file -- you have to do something
> special in the meson.build file for the files that include it.
> Paolo can tell you what that is, I expect.

OK, I missed the CI results as it was all working for me.  I will fix and test
with the same as CI configs.

-Stafford

> Paolo: are we going to be able to stop doing this at some point
> and get meson to just DTRT and put includes on the path for
> every C file ?
> 
> thanks
> -- PMM


      reply	other threads:[~2022-02-26  1:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25  8:32 [PULL 0/6] OpenRISC DTS Generation patches for 7.0 Stafford Horne
2022-02-25  8:32 ` [PULL 1/6] hw/openrisc/openrisc_sim: Create machine state for or1ksim Stafford Horne
2022-02-25  8:32 ` [PULL 2/6] hw/openrisc/openrisc_sim: Parameterize initialization Stafford Horne
2022-02-25  8:32 ` [PULL 3/6] hw/openrisc/openrisc_sim: Use IRQ splitter when connecting UART Stafford Horne
2022-02-25  8:32 ` [PULL 4/6] hw/openrisc/openrisc_sim: Increase max_cpus to 4 Stafford Horne
2022-02-25  8:32 ` [PULL 5/6] hw/openrisc/openrisc_sim: Add automatic device tree generation Stafford Horne
2022-02-25  8:32 ` [PULL 6/6] hw/openrisc/openrisc_sim: Add support for initrd loading Stafford Horne
2022-02-25 13:52 ` [PULL 0/6] OpenRISC DTS Generation patches for 7.0 Peter Maydell
2022-02-26  1:22   ` Stafford Horne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhmAwx67OUmPFQ5F@antec \
    --to=shorne@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).