From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/
Date: Mon, 28 Feb 2022 11:14:04 +0000 [thread overview]
Message-ID: <YhyufAWVPGSiDSQY@redhat.com> (raw)
In-Reply-To: <CAFEAcA-MrYMhYDiwvAV8zgtFrbQTR6m5pOkwWuWOtX3fcrdNSQ@mail.gmail.com>
On Mon, Feb 28, 2022 at 11:07:19AM +0000, Peter Maydell wrote:
> On Mon, 28 Feb 2022 at 09:13, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > We only support the current major release, and thue previous major
> > release for 2 years overlap. If we consider 11.x releases as major,
> > then 11.3 went out of scope from QEMU's POV in Aug 2020, and thus
> > we don't need to care about this code.
> >
> > More generally though, Solaris isn't even a platform we try to
> > support at all is it ?
> >
> > We've never had any formal testing on it. Have we seen people filing
> > bugs mentioning solaris in the last 5 years ? If QEMU works at all,
> > I suspect it is merely by luck.
>
> This last came up in June 2020:
> https://lore.kernel.org/qemu-devel/CAEgYsbE7s5hD+5ARj_Xt1D0ALDPDQx7uvocd5zRF6P=EzwxTZQ@mail.gmail.com/
>
> where somebody pointed out that illumos also doesn't (didn't?)
> support openpty(). So we do have at least one or two people
> who have tried to compile on Solaris and been enthusiastic
> enough to post to the mailing list about it.
Ah yes, and we even updated the comment to say we're keeping this for
Illumos, not for Solaris
commit 9df8b20d1632d108da316134d4d86a00b4028803
Author: Thomas Huth <thuth@redhat.com>
Date: Mon Jun 29 14:13:24 2020 +0200
configure / util: Auto-detect the availability of openpty()
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-02-28 11:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 19:40 [PATCH 0/8] Misc build fixes and cleanups marcandre.lureau
2022-02-22 19:40 ` [PATCH 1/8] meson: fix generic location of vss headers marcandre.lureau
2022-02-22 19:40 ` [PATCH 2/8] qga/vss-win32: check old VSS SDK headers marcandre.lureau
2022-02-22 19:40 ` [PATCH 3/8] qga/vss: update informative message about MinGW marcandre.lureau
2022-02-22 19:40 ` [PATCH 4/8] meson: drop the .fa library suffix marcandre.lureau
2022-02-23 9:07 ` Paolo Bonzini
2022-02-23 9:14 ` Marc-André Lureau
2022-02-24 14:01 ` Paolo Bonzini
2022-02-22 19:40 ` [PATCH 5/8] meson: use chardev_ss dependencies marcandre.lureau
2022-02-22 19:40 ` [PATCH 6/8] char: move qemu_openpty_raw from util/ to char/ marcandre.lureau
2022-02-24 17:04 ` Marc-André Lureau
2022-02-26 7:38 ` Paolo Bonzini
2022-02-28 7:53 ` Marc-André Lureau
2022-02-28 9:13 ` Daniel P. Berrangé
2022-02-28 11:07 ` Peter Maydell
2022-02-28 11:14 ` Daniel P. Berrangé [this message]
2022-02-22 19:40 ` [PATCH 7/8] Drop qemu_foo() socket API wrapper marcandre.lureau
2022-02-22 21:26 ` Philippe Mathieu-Daudé
2022-02-24 15:53 ` Eric Blake
2022-02-22 19:40 ` [PATCH 8/8] Replace GCC_FMT_ATTR with G_GNUC_PRINTF marcandre.lureau
2022-02-24 14:03 ` [PATCH 0/8] Misc build fixes and cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhyufAWVPGSiDSQY@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).