From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Simeon Schaub <schaub@mit.edu>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] explicitly link libqemuutil against rt
Date: Mon, 28 Feb 2022 14:38:25 +0000 [thread overview]
Message-ID: <YhzeYQ7akrGqAIW7@redhat.com> (raw)
In-Reply-To: <CAFEAcA-dStng7OmArapZTMXx=fF9cme3VftLAAd-nQgcv0ZgGA@mail.gmail.com>
On Mon, Feb 28, 2022 at 02:15:11PM +0000, Peter Maydell wrote:
> On Mon, 28 Feb 2022 at 14:12, Simeon Schaub <schaub@mit.edu> wrote:
> >
> > >From e77de12cc33846a3de71d1858e497fbf4cdbff96 Mon Sep 17 00:00:00 2001
> > From: Simeon David Schaub <schaub@mit.edu>
> > Date: Sun, 27 Feb 2022 22:59:19 -0500
> > Subject: [PATCH] explicitly link libqemuutil against rt
> >
> > Qemu uses `clock_gettime` which is already part of more recent versions
> > of glibc, but on older versions it is still required to link against
> > librt.
>
> Which version of glibc are you seeing this with ?
The man page says
"Link with -lrt (only for glibc versions before 2.17)."
and even ancient RHEL-7 had glibc 2.17, so I can't imagine any platform
we currently target in QEMU has a glibc older than 2.17, so QEMU should
not need this change, unless there's some other scenario not described
in the commit message.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-02-28 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 4:16 [PATCH] explicitly link libqemuutil against rt Simeon Schaub
2022-02-28 14:15 ` Peter Maydell
2022-02-28 14:38 ` Daniel P. Berrangé [this message]
2022-02-28 15:12 ` Peter Maydell
2022-02-28 15:13 ` Simeon Schaub
2022-02-28 15:17 ` Peter Maydell
2022-02-28 15:29 ` Simeon Schaub
2022-02-28 16:08 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhzeYQ7akrGqAIW7@redhat.com \
--to=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=schaub@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).