From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2336C433F5 for ; Mon, 14 Mar 2022 18:55:59 +0000 (UTC) Received: from localhost ([::1]:52318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTprK-0002sB-TY for qemu-devel@archiver.kernel.org; Mon, 14 Mar 2022 14:55:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTppn-0001mP-Od for qemu-devel@nongnu.org; Mon, 14 Mar 2022 14:54:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:43148) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTppl-0003WN-PR for qemu-devel@nongnu.org; Mon, 14 Mar 2022 14:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647284060; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dcbhIrzTigZ4WxMe1bkx5Tym9p5SQU29bd7Nd2VaeyE=; b=RLcAoa0SQJ6mQomeIXznmRKo6Yb9VVOazyuC+O0fGJ8MGxJvve90A6ZeK/rcnsCQA+gweV HQ8OFWlSyUkSMAcJX4lvdKwRIy5QHAPYTjwyWiDDTpwWsrBRsBQhkSV1ZLHLB2yc4g66rE EE1oGfYU3+zw9wx4D3Yq1yrraNtOwbU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-43-hAYrWUQVOUOJnZxeRcQb0g-1; Mon, 14 Mar 2022 14:54:06 -0400 X-MC-Unique: hAYrWUQVOUOJnZxeRcQb0g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B20CC1C05AD4; Mon, 14 Mar 2022 18:53:37 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E078A5E3A35; Mon, 14 Mar 2022 18:53:32 +0000 (UTC) Date: Mon, 14 Mar 2022 18:53:29 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Dr. David Alan Gilbert" Subject: Re: [PULL 00/18] migration queue Message-ID: References: <20220302182936.227719-1-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , thuth@redhat.com, quintela@redhat.com, s.reiter@proxmox.com, qemu-devel@nongnu.org, peterx@redhat.com, "open list:S390 general arch..." , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , hreitz@redhat.com, f.ebner@proxmox.com, jinpu.wang@ionos.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 14, 2022 at 06:20:54PM +0000, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.maydell@linaro.org) wrote: > > On Mon, 14 Mar 2022 at 17:55, Dr. David Alan Gilbert > > wrote: > > > > > > Peter Maydell (peter.maydell@linaro.org) wrote: > > > > One thing that makes this bug investigation trickier, incidentally, > > > > is that the migration-test code seems to depend on userfaultfd. > > > > That means you can't run it under 'rr'. > > > > > > That should only be the postcopy tests; the others shouldn't use that. > > > > tests/qtest/migration-test.c:main() exits immediately without adding > > any of the test cases if ufd_version_check() fails, so no userfaultfd > > means no tests run at all, currently. > > Ouch! I could swear we had a fix for that. > > Anyway, it would be really good to see what migrate-query was returning; > if it's stuck in running or cancelling then it's a problem with multifd > that needs to learn to let go if someone is trying to cancel. > If it's failed or similar then the test needs fixing to not lockup. This patch of mine may well be helpful: https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg03192.html when debugging my TLS tests various mistakes meant I ended up with a failed session, but the test was spinning forever on 'query-migrate'. It was waiting for it to finish one iteration, and never bothering to validate that the reported status == active. If that patch was merged, it might well cause the test to abort in an assertion rather than spining forever, if status == failed. Of course someone would still need to find out why it failed, but none the less, I think assert is nicer than spin forever. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|