From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 921B7C433F5 for ; Fri, 4 Mar 2022 18:04:35 +0000 (UTC) Received: from localhost ([::1]:59220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQCI6-0000z4-G4 for qemu-devel@archiver.kernel.org; Fri, 04 Mar 2022 13:04:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQC4q-0002Pb-Df for qemu-devel@nongnu.org; Fri, 04 Mar 2022 12:50:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:34202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQC4n-0002mr-3V for qemu-devel@nongnu.org; Fri, 04 Mar 2022 12:50:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646416248; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/e/xJHlmCfzkUIIFdzmM0iuoWG7zzjvrq1dpsuOntVk=; b=hStmuMFER9AhBxBsYAx+EgW3Md1CXXlaaeN3xheGr3g53SAlD0fg7opPaeAdTSWFT6n5rC oX+KtEeC4WNwvuSN1ozdJuLM5IhXJeNSldnxM0dUQV0QOm8kFs5UiMxuYi9RnZpcCkTn03 U5rb7bvYVYGkKJ+FuJmH/PJtH7MoS8U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-253-fFqYqdJxPSqM1_ULgGu_zw-1; Fri, 04 Mar 2022 12:50:45 -0500 X-MC-Unique: fFqYqdJxPSqM1_ULgGu_zw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F1D41091DA0; Fri, 4 Mar 2022 17:50:44 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E3CE85EE5; Fri, 4 Mar 2022 17:50:42 +0000 (UTC) Date: Fri, 4 Mar 2022 17:50:39 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Subject: Re: [PATCH 03/10] python/aqmp: remove _new_session and _establish_connection Message-ID: References: <20220225205948.3693480-1-jsnow@redhat.com> <20220225205948.3693480-4-jsnow@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220225205948.3693480-4-jsnow@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Peter Maydell , Cleber Rosa , qemu-devel@nongnu.org, Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Feb 25, 2022 at 03:59:41PM -0500, John Snow wrote: > These two methods attempted to entirely envelop the logic of > establishing a connection to a peer start to finish. However, we need to > break apart the incoming connection step into more granular steps. We > will no longer be able to reasonably constrain the logic inside of these > helper functions. > > So, remove them - with _session_guard(), they no longer serve a real > purpose. > > Although the public API doesn't change, the internal API does. Now that > there are no intermediary methods between e.g. connect() and > _do_connect(), there's no hook where the runstate is set. As a result, > the test suite changes a little to cope with the new semantics of > _do_accept() and _do_connect(). > > Lastly, take some pieces of the now-deleted docstrings and move > them up to the public interface level. They were a little more detailed, > and it won't hurt to keep them. > > Signed-off-by: John Snow > --- > python/qemu/aqmp/protocol.py | 117 ++++++++++++++--------------------- > python/tests/protocol.py | 10 ++- > 2 files changed, 53 insertions(+), 74 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|