From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F35F4C433FE for ; Fri, 4 Mar 2022 18:37:42 +0000 (UTC) Received: from localhost ([::1]:60028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQCoA-0008SN-3K for qemu-devel@archiver.kernel.org; Fri, 04 Mar 2022 13:37:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQCDQ-0006PD-Ma for qemu-devel@nongnu.org; Fri, 04 Mar 2022 12:59:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQCDO-00045k-S1 for qemu-devel@nongnu.org; Fri, 04 Mar 2022 12:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646416782; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H9nENM5nmaYU8AW5Bn1EMtRjTx1iyr3GqrpnpS8EjD0=; b=Bi81yZ1yhGqIazq6M1U/wGZr87sSRze4n7gKE2rhoQ3tPG7vFFBFjZB30v5uNsv/qwMmpN +DHUF2gwkdeM3KpPx2OWuZ7iroBprPHsHy+Ek/d7ctPq4ZO7aBKuxBkmnQ6cBjUATFAY2O rbnkDE6Lev9c+y8r0SV3cSXzX852zyU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-_qlS9jpZOjy_Ow_13LgUsA-1; Fri, 04 Mar 2022 12:59:35 -0500 X-MC-Unique: _qlS9jpZOjy_Ow_13LgUsA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84EC81006AA5; Fri, 4 Mar 2022 17:59:34 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6FCB865AA; Fri, 4 Mar 2022 17:59:32 +0000 (UTC) Date: Fri, 4 Mar 2022 17:59:26 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Subject: Re: [PATCH 08/10] python/aqmp: add start_server() and accept() methods Message-ID: References: <20220225205948.3693480-1-jsnow@redhat.com> <20220225205948.3693480-9-jsnow@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220225205948.3693480-9-jsnow@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Peter Maydell , Cleber Rosa , qemu-devel@nongnu.org, Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Feb 25, 2022 at 03:59:46PM -0500, John Snow wrote: > Add start_server() and accept() methods that can be used instead of > start_server_and_accept() to allow more fine-grained control over the > incoming connection process. > > (Eagle-eyed reviewers will surely notice that it's a bit weird that > "CONNECTING" is a state that's shared between both the start_server() > and connect() states. That's absolutely true, and it's very true that > checking on the presence of _accepted as an indicator of state is a > hack. That's also very certainly true. But ... this keeps client code an > awful lot simpler, as it doesn't have to care exactly *how* the > connection is being made, just that it *is*. Is it worth disrupting that > simplicity in order to provide a better state guard on `accept()`? Hm.) > > Signed-off-by: John Snow > --- > python/qemu/aqmp/protocol.py | 67 +++++++++++++++++++++++++++++++++--- > python/tests/protocol.py | 7 ++++ > 2 files changed, 69 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|