Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type

[Patrick Williams <patrick@stwcx.xyz>]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

On Sat, Mar 05, 2022 at 08:57:47AM +0100, Cédric Le Goater wrote:
> On 3/5/22 01:06, Patrick Williams wrote:
> > +    mc->desc       = "Facebook Bletchley BMC (Cortex-A7)";
> > +    amc->soc_name  = "ast2600-a3";
> > +    amc->hw_strap1 = BLETCHLEY_BMC_HW_STRAP1;
> > +    amc->hw_strap2 = BLETCHLEY_BMC_HW_STRAP2;
> > +    amc->fmc_model = "w25q01jvq";
> 
> So we need this patch :
> 
> http://patchwork.ozlabs.org/project/qemu-devel/patch/20220304180920.1780992-1-patrick@stwcx.xyz/
> 
> May be I can take it through my queue.

Yes, it does.  I had sent that one earlier and probably should have been clear
on the dependency.

> > +    amc->spi_model = NULL;
> > +    amc->num_cs    = 1;
> 
> There are two flash devices on the FMC. I can fix it inline since
> it is the only change I would request.

Yes, there are.  I think all of the Facebook systems have dual FMC, for
redundancy in hardware, but we can get by in QEMU with just a single one.

I'll see however you fix it up and see I can update all the other systems as
well.  We have an internal patch to expand the CS on FMC to 2 but we haven't
upstreamed it yet and I'm worried it will break some users w.r.t. the CLI
changing for adding images.  My recollection is that the Romulus CI on OpenBMC
relies on the PNOR being the 2nd argument.

> Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thank you Cedric!

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]