From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5ACDAC433F5 for ; Mon, 7 Mar 2022 21:01:18 +0000 (UTC) Received: from localhost ([::1]:58078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRKTl-0001bu-9P for qemu-devel@archiver.kernel.org; Mon, 07 Mar 2022 16:01:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKSa-0000PC-7s; Mon, 07 Mar 2022 16:00:04 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:42489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKSX-00065I-LU; Mon, 07 Mar 2022 16:00:03 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AC7573201591; Mon, 7 Mar 2022 15:59:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 07 Mar 2022 15:59:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=VfF/lfkCnVIztWt1SfQiW6wBMzSe3jDAyVa65G mXEXo=; b=wv0X+Ep26ezFc4zFs/WSsyOtvJC7B3G8B+VfXb6BFtPLBfMlCJ+seV BpygneL6M/087XpsmgW9mpoj93e0VCh65l/MtfJ7sjz4w3WaUMzcXNftvzfd4tKJ QTFkDcD/5eKdHTOWyirTJEj190fvalwFX5hqUihnBJdtZ3tEHbqe2qKsb0oueHF7 RxGn7guj+N2Lo+H7TFKPibsUXKgG3Agat2D/vw5leJLK0LI6wEGyPN3F4XuTrmms B4yvRnS46f3DIYNfuaAfFfgbyp5cjZySGn6CmyH1ZPsQmSyJfFL+JErYdL0h3YXL e3d5EF7pSglpXIwXIuJJGWfYhzsmDaSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=VfF/lfkCnVIztWt1S fQiW6wBMzSe3jDAyVa65GmXEXo=; b=NweEEM01m1hOH8LUB4vQF5i+Ya59XU75Y fwzvF6MzC58hyznvM2pGjmT+xqFdIeyctCNOBCIKFxpLXsZgMw16iR2S6VAbk86k YWxgAQAQR77JW6jb8d3eYyu01Gjs39uunHAZUxk6AqmpQbr+7RrknNPLsdTYg7FG vLS2uh+tLZnPogMZ80UcSa753fYn7AmxvKe1oSUzkjU2m0ar4cWSPfgfBUpPzCpr GSdfYuhzjk0dxHMHsA3ZRxGVlA1imbjXYPT609dAJWFekC2fhO4Ur7DPXZeI3KnF XH70nZxq54sjatLL7Hv6Aja0luNuJoM2U1B2Za1btXpkGTV3d+QAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddugedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdefhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredt tddunecuhfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghkse hsthiftgigrdighiiiqeenucggtffrrghtthgvrhhnpeehgfektdefuedvvdffgeevleej vddvgeeltedtfedutdeuheeljeduveeiudeileenucffohhmrghinhepohiilhgrsghsrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep phgrthhrihgtkhesshhtfigtgidrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Mar 2022 15:59:56 -0500 (EST) Date: Mon, 7 Mar 2022 14:59:54 -0600 From: Patrick Williams To: =?iso-8859-1?Q?C=E9dric?= Le Goater Subject: Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type Message-ID: References: <20220305000656.1944589-1-patrick@stwcx.xyz> <20220305000656.1944589-2-patrick@stwcx.xyz> <790dd79a-4c5e-207e-86a9-9351694f0427@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hqE6ApmCJkxtP0qK" Content-Disposition: inline In-Reply-To: <790dd79a-4c5e-207e-86a9-9351694f0427@kaod.org> Received-SPF: pass client-ip=64.147.123.21; envelope-from=patrick@stwcx.xyz; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.997, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , "open list:ASPEED BMCs" , Joel Stanley , "open list:All patches CC here" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --hqE6ApmCJkxtP0qK Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 05, 2022 at 08:57:47AM +0100, C=E9dric Le Goater wrote: > On 3/5/22 01:06, Patrick Williams wrote: > > + mc->desc =3D "Facebook Bletchley BMC (Cortex-A7)"; > > + amc->soc_name =3D "ast2600-a3"; > > + amc->hw_strap1 =3D BLETCHLEY_BMC_HW_STRAP1; > > + amc->hw_strap2 =3D BLETCHLEY_BMC_HW_STRAP2; > > + amc->fmc_model =3D "w25q01jvq"; >=20 > So we need this patch : >=20 > http://patchwork.ozlabs.org/project/qemu-devel/patch/20220304180920.17809= 92-1-patrick@stwcx.xyz/ >=20 > May be I can take it through my queue. Yes, it does. I had sent that one earlier and probably should have been cl= ear on the dependency. > > + amc->spi_model =3D NULL; > > + amc->num_cs =3D 1; >=20 > There are two flash devices on the FMC. I can fix it inline since > it is the only change I would request. Yes, there are. I think all of the Facebook systems have dual FMC, for redundancy in hardware, but we can get by in QEMU with just a single one. I'll see however you fix it up and see I can update all the other systems as well. We have an internal patch to expand the CS on FMC to 2 but we haven't upstreamed it yet and I'm worried it will break some users w.r.t. the CLI changing for adding images. My recollection is that the Romulus CI on Open= BMC relies on the PNOR being the 2nd argument. > Reviewed-by: C=E9dric Le Goater Thank you Cedric! --=20 Patrick Williams --hqE6ApmCJkxtP0qK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmImckgACgkQqwNHzC0A wRl7Og/+OqDSTEVmC7Ws+xKFMeqW0q1Z26F/e390S9q3rfpj5oObDQuWDZh2fwj7 MeMre1fQS8gdD5R1vJaZeJxedufzDK0Sq0ohe4iajonNYQWGE/Nk8PI8xX1Yl+2Y AUGM3qdQg/F+/0vUGnZeO2dCMjbu9cG3WlTRNf7i/TIcP7iMCzTosaFl+LKyoxxE Jee6imCtkMf0K33xdWK56LiOBjU/ycPJJjcXoWMBCX3o0UunzqtjpBa7sXeejvha YuB0COjcy/oVPacQIS3ajwp58ecPRMMy438XkwCEJ7d0NjB4fNOvmjFoZVojhNK5 VzKtYmU/xd2yxUb+9YT+tQYMFklNn2YkxgYPuwEe5p69YsMcOqKpyWg6DIxk93Th 4HDMSmeoH+LQtPMez9unrafpgccWkbBR1JkAIHkq2uXr+EDeFgZBOCqBz1KdavDO PcWbFjQxAFokeAlzWglFdELFNoSptvlOLhgoiuzFkbOpvjUNe7wkverrc4NiDc+o /DE1DuIgLx66OcDc8pkU/iWRnDH29msDuvssoz+SgWchECxdyj0vKYW8E4fFI0tv qL0qbS86QOS5MkXvMHnP1U5hVab8wZ75nNhMVg1HBx4hWqUdUIYJXxmYWyUumXol HB7mCkreIULFPuWl5jMyGyyY8vr7tEBp7QEKg/FPi8LC76cRkcY= =O0z9 -----END PGP SIGNATURE----- --hqE6ApmCJkxtP0qK--