From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65C0BC433EF for ; Tue, 8 Mar 2022 18:11:17 +0000 (UTC) Received: from localhost ([::1]:37082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nReIl-00043q-Sb for qemu-devel@archiver.kernel.org; Tue, 08 Mar 2022 13:11:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRdYu-0007tm-CL; Tue, 08 Mar 2022 12:23:52 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRdYs-0001J4-20; Tue, 08 Mar 2022 12:23:52 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A96775C023B; Tue, 8 Mar 2022 12:23:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 08 Mar 2022 12:23:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=PblPKJKnQsWifKsz1wXrgpG1CM9B25GQuj8v8p eIu+w=; b=f+QfS0dSexZ2Dnp7XForvH8kzgYIr/ATtuM1pvUtEdZDE+b3/caowR G2md4XB+nL0iTUgf8mzMG8Wr4oyBAkia+7iz0/ZdOfQI5hwbzU4aPM6GyoGzrZX2 plLSJgkp9Kij2hw2hWBAWEClbb9AZZ+bQubOqNKS+GGUH7NUZlrwtrfkuMKbaxdx Ld6gHMwGXK/XNCHVR3gSMtkZ5Dqv8NQHQKmvkNCnCDYONvZr0cbMe5JmHqol6FT7 1RBVmPYwQTej7XCOuOu2obl+IUtPpGKRzl98fj0jxemJFSXI9U5mj024kgOGI8M6 2veAyJ+KkMPWhCZfvLIKauC3sq/MPu7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=PblPKJKnQsWifKsz1 wXrgpG1CM9B25GQuj8v8peIu+w=; b=OUM+5bNEPCvzS1T1fhW2WfLFwd5Jmx0HH zg0dtD+Icw0DlPqvJLJKTOgupawG3QK5F4uWMhUVXYuP5aatjBjEECRx+kH53qAR MQIydyh4BFExnFmEpu96fCrBmOA40COHz9MhpjXm6LPQ5eidZUwELN6br1bdjw8I vCHxIvazLkemrMxIRlmE8nhW308dp9XtsO019BsjORR9xNOgcfPf2CT+LLk/Z3m9 LxBxs1EuBqYYXnDizYhGzcqp2M0Vso754zjmIcouU9PV5j3PqUiNmsd0NxgZn7FK vxpzztkJlgchQU+NinvozfH7++8duSKEL2kbCm+mXuahJparuNdug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtroertddt udenucfhrhhomheprfgrthhrihgtkhcuhghilhhlihgrmhhsuceophgrthhrihgtkhessh htfigtgidrgiihiieqnecuggftrfgrthhtvghrnhepvddvgedtudffiedugffgveffiefh ieevteegieegvdejvdfhgffhudfhgeegfefhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphgrthhrihgtkhesshhtfigtgidrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 12:23:47 -0500 (EST) Date: Tue, 8 Mar 2022 11:23:46 -0600 From: Patrick Williams To: =?iso-8859-1?Q?C=E9dric?= Le Goater Subject: Re: [PATCH 2/2] hw/arm/aspeed: add Bletchley machine type Message-ID: References: <20220305000656.1944589-1-patrick@stwcx.xyz> <20220305000656.1944589-2-patrick@stwcx.xyz> <790dd79a-4c5e-207e-86a9-9351694f0427@kaod.org> <2b9aed65-5cdf-0647-dc25-7cc9d488aaa6@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EwE2bW6bcZ26nGcO" Content-Disposition: inline In-Reply-To: <2b9aed65-5cdf-0647-dc25-7cc9d488aaa6@kaod.org> Received-SPF: pass client-ip=66.111.4.25; envelope-from=patrick@stwcx.xyz; helo=out1-smtp.messagingengine.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, PDS_OTHER_BAD_TLD=1.997, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , "open list:ASPEED BMCs" , Joel Stanley , "open list:All patches CC here" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --EwE2bW6bcZ26nGcO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 08, 2022 at 09:14:07AM +0100, C=E9dric Le Goater wrote: >=20 > >> There are two flash devices on the FMC. I can fix it inline since > >> it is the only change I would request. > >=20 > > Yes, there are. I think all of the Facebook systems have dual FMC, for > > redundancy in hardware, but we can get by in QEMU with just a single on= e. >=20 > yes, the kernel will complain though and I don't know how robust > the spi-nor based driver is. I think you sent a patch for a related > issue. >=20 > The newer spi-mem driver should be fine. Oh yes. I already forgot that I'm running with that patch since Joel added= it to our backport 5.15 branch. One of the reasons I wrote that patch was to = make QEMU not kpanic. :( > =20 > > I'll see however you fix it up and see I can update all the other syste= ms as > > well. =20 >=20 > ok. may be for 7.1 then. >=20 > > We have an internal patch to expand the CS on FMC to 2 but we haven't > > upstreamed it yet and I'm worried it will break some users w.r.t. the C= LI > > changing for adding images. =20 >=20 > Yes. That's the problem. I am afraid some CI systems will break with > these change in a newer QEMU. The command line options will need to > adapt. My recollection is that the Romulus CI uses a branch of QEMU that at this p= oint is rather old anyhow. We should be able to fix up the CI scripts at the sa= me time we upgrade. Are you or Andrew J maintaining that branch? > > My recollection is that the Romulus CI on OpenBMC relies on the PNOR=20 > > being the 2nd argument. >=20 > That's the initial assumption made years ago. First mtd device is FMC, > second is the PNOR. It is reaching its limits. >=20 > I am looking at improving the command line argument to support: >=20 > -drive file=3D,format=3Draw,id=3Ddrive0 -device mx66l1g45g,bus= =3Dssi.0,drive=3Ddrive0 >=20 > which we would clearly define the topology. Adding a cs=3D[0-5] or and > addr=3D[0-5] is the next step. Seems fine to me. --=20 Patrick Williams --EwE2bW6bcZ26nGcO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmInkSAACgkQqwNHzC0A wRkw6xAAgPgCGRzRydtSJERruguu810ew1LX32fV8Eqtq82BIOVO3WRc2J4fU8Ah Lfa2LamrS261G270uE/udu2Idzv7fxtA2x7hBzUumW+luwR7qE8gvLKCrc1gOPFi Zux3I7uOIfnDouuh8X9Is43470HyQTP564JoGUzPjGZ33iZiMABhLmhfKXsZcRj7 vsuT/cAOxJ6B0EA8e/6G6Z9DZJaC1cPVQdyIkQKwpd24rioPT0sTnjjXUm5aWBpA IeKvDg6FXaRvyp6OFz3CyoPUyJiG0gHi3LoNEGCeuDE/HnYgteETFVhs26M+tg4G BaV+/eW8QuuzErRTVrMe6ztIYZvQKD+x8Bqu9ETqKPwVYKX9AgKhezHHxldF9NEt Z07x463l7Abcs13N4yrFP7iQ2Yyxbpo8bEFVkF1Y8l54dHRnLn4dsU6rbBS6xwVR HAbMVViTdFT2sWuF1nVvxXMQHq6wJIofXGJlC9Na0EA1wgoj2b4jn8yut2pj23nn HPu+4UZMkTcLoliZ6gFBAxDwdbOY7FDKPaUx7r80exy6PzPe5O8CJXo07QRCm3rA T/eoOKdi58xXBIdUx3EKY38lZFrgCRxhnFtVUjOglgZuwymK1aUa3YujveNE6RmC QTsctzWmf39JO+Uia/bDQqpiiDliWXLR9GRH7HtfbaqJhdVl38s= =QCQj -----END PGP SIGNATURE----- --EwE2bW6bcZ26nGcO--