From: Stefan Hajnoczi <stefanha@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: kwolf@redhat.com, fam@euphon.net, berrange@redhat.com,
qemu-block@nongnu.org, michael.roth@amd.com, mtosatti@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, eduardo@habkost.net,
hreitz@redhat.com, pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH v2 2/4] Introduce event-loop-base abstract class
Date: Thu, 10 Mar 2022 10:25:19 +0000 [thread overview]
Message-ID: <YinSD8xxujd5lOSy@stefanha-x1.localdomain> (raw)
In-Reply-To: <20220303145822.518887-3-nsaenzju@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Thu, Mar 03, 2022 at 03:58:20PM +0100, Nicolas Saenz Julienne wrote:
> @@ -2935,13 +2947,6 @@ qemu_syms = custom_target('qemu.syms', output: 'qemu.syms',
> capture: true,
> command: [undefsym, nm, '@INPUT@'])
>
> -qom_ss = qom_ss.apply(config_host, strict: false)
> -libqom = static_library('qom', qom_ss.sources() + genh,
> - dependencies: [qom_ss.dependencies()],
> - name_suffix: 'fa')
> -
> -qom = declare_dependency(link_whole: libqom)
> -
Why was it necessary to move qom_ss and subdir('hw') up? Can
event_loop_base be defined down here instead?
(The benefit of less code churn is it reduces the risk of patch conflicts.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-10 10:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 14:58 [PATCH v2 0/4] util/thread-pool: Expose minimun and maximum size Nicolas Saenz Julienne
2022-03-03 14:58 ` [PATCH v2 1/4] util/thread-pool: Fix thread pool freeing locking Nicolas Saenz Julienne
2022-03-10 9:20 ` Stefan Hajnoczi
2022-03-10 10:09 ` Nicolas Saenz Julienne
2022-03-03 14:58 ` [PATCH v2 2/4] Introduce event-loop-base abstract class Nicolas Saenz Julienne
2022-03-10 10:25 ` Stefan Hajnoczi [this message]
2022-03-11 10:17 ` Nicolas Saenz Julienne
2022-03-14 13:33 ` Stefan Hajnoczi
2022-03-14 13:34 ` Nicolas Saenz Julienne
2022-03-03 14:58 ` [PATCH v2 3/4] util/main-loop: Introduce the main loop into QOM Nicolas Saenz Julienne
2022-03-10 10:27 ` Stefan Hajnoczi
2022-03-03 15:13 ` [PATCH v2 4/4] util/event-loop-base: Introduce options to set the thread pool size Nicolas Saenz Julienne
2022-03-10 10:45 ` Stefan Hajnoczi
2022-03-11 10:40 ` Nicolas Saenz Julienne
2022-03-14 13:35 ` Stefan Hajnoczi
2022-03-14 17:19 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YinSD8xxujd5lOSy@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=mtosatti@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).