qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: kwolf@redhat.com, fam@euphon.net, berrange@redhat.com,
	qemu-block@nongnu.org, michael.roth@amd.com, mtosatti@redhat.com,
	qemu-devel@nongnu.org, armbru@redhat.com, eduardo@habkost.net,
	hreitz@redhat.com, pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH v2 3/4] util/main-loop: Introduce the main loop into QOM
Date: Thu, 10 Mar 2022 10:27:06 +0000	[thread overview]
Message-ID: <YinSemh7dAelx0lL@stefanha-x1.localdomain> (raw)
In-Reply-To: <20220303145822.518887-4-nsaenzju@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

On Thu, Mar 03, 2022 at 03:58:21PM +0100, Nicolas Saenz Julienne wrote:
> 'event-loop-base' provides basic property handling for all 'AioContext'
> based event loops. So let's define a new 'MainLoopClass' that inherits
> from it. This will permit tweaking the main loop's properties through
> qapi as well as through the command line using the '-object' keyword[1].
> Only one instance of 'MainLoopClass' might be created at any time.
> 
> 'EventLoopBaseClass' learns a new callback, 'can_be_deleted()' so as to
> mark 'MainLoop' as non-deletable.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> 
> [1] For example:
>       -object main-loop,id=main-loop,aio-max-batch=<value>
> ---
> 
> Changes since v1:
>  - Fix json files to differentiate between iothread and main-loop
>  - Use OBJECT_DECLARE_TYPE()
>  - Fix build dependencies
> 
>  event-loop-base.c                | 13 ++++++++
>  include/qemu/main-loop.h         | 10 ++++++
>  include/sysemu/event-loop-base.h |  1 +
>  meson.build                      |  3 +-
>  qapi/qom.json                    | 16 +++++++++
>  util/main-loop.c                 | 56 ++++++++++++++++++++++++++++++++
>  6 files changed, 98 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-03-10 10:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 14:58 [PATCH v2 0/4] util/thread-pool: Expose minimun and maximum size Nicolas Saenz Julienne
2022-03-03 14:58 ` [PATCH v2 1/4] util/thread-pool: Fix thread pool freeing locking Nicolas Saenz Julienne
2022-03-10  9:20   ` Stefan Hajnoczi
2022-03-10 10:09     ` Nicolas Saenz Julienne
2022-03-03 14:58 ` [PATCH v2 2/4] Introduce event-loop-base abstract class Nicolas Saenz Julienne
2022-03-10 10:25   ` Stefan Hajnoczi
2022-03-11 10:17     ` Nicolas Saenz Julienne
2022-03-14 13:33       ` Stefan Hajnoczi
2022-03-14 13:34         ` Nicolas Saenz Julienne
2022-03-03 14:58 ` [PATCH v2 3/4] util/main-loop: Introduce the main loop into QOM Nicolas Saenz Julienne
2022-03-10 10:27   ` Stefan Hajnoczi [this message]
2022-03-03 15:13 ` [PATCH v2 4/4] util/event-loop-base: Introduce options to set the thread pool size Nicolas Saenz Julienne
2022-03-10 10:45   ` Stefan Hajnoczi
2022-03-11 10:40     ` Nicolas Saenz Julienne
2022-03-14 13:35       ` Stefan Hajnoczi
2022-03-14 17:19         ` Nicolas Saenz Julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YinSemh7dAelx0lL@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=fam@euphon.net \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mtosatti@redhat.com \
    --cc=nsaenzju@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).