From: David Gibson <david@gibson.dropbear.id.au>
To: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org
Subject: Re: [PATCH 0/2] ppc: fix vcpu hotunplug leak in spapr_realize_vcpu
Date: Tue, 29 Mar 2022 12:24:20 +1100 [thread overview]
Message-ID: <YkJfxLJkxZQDQwch@yekko> (raw)
In-Reply-To: <20220328125918.494787-1-danielhb413@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On Mon, Mar 28, 2022 at 09:59:16AM -0300, Daniel Henrique Barboza wrote:
> Hi,
>
> This is a memory leak found by Valgrind when testing vcpu
> hotplug/unplug in pSeries guests.
>
> Other vcpu hotplug/unplug leaks are still present in the common code
> (one in the KVM thread loop and another in cpu_address_space via
> cpu->cpu_ases) but these are already being handled by Mark Kanda and
> Phillipe.
Changes LGTM, but I don't see much reason to split this into two
patches. They're both small, and are part of the same logical change.
>
>
> Daniel Henrique Barboza (2):
> hw/ppc/ppc.c: add cpu_ppc_tb_free()
> hw/ppc: free env->tb_env in spapr_unrealize_vcpu()
>
> hw/ppc/ppc.c | 7 +++++++
> hw/ppc/spapr_cpu_core.c | 3 +++
> include/hw/ppc/ppc.h | 1 +
> 3 files changed, 11 insertions(+)
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-29 1:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 12:59 [PATCH 0/2] ppc: fix vcpu hotunplug leak in spapr_realize_vcpu Daniel Henrique Barboza
2022-03-28 12:59 ` [PATCH 1/2] hw/ppc/ppc.c: add cpu_ppc_tb_free() Daniel Henrique Barboza
2022-03-28 12:59 ` [PATCH 2/2] hw/ppc: free env->tb_env in spapr_unrealize_vcpu() Daniel Henrique Barboza
2022-03-29 1:24 ` David Gibson [this message]
2022-03-29 8:36 ` [PATCH 0/2] ppc: fix vcpu hotunplug leak in spapr_realize_vcpu Cédric Le Goater
2022-03-29 9:32 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkJfxLJkxZQDQwch@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).