qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
	Klaus Jensen <k.jensen@samsung.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 4/5] hw/nvme: do not auto-generate uuid
Date: Wed, 20 Apr 2022 07:51:32 +0200	[thread overview]
Message-ID: <Yl+fZI5kGW2wQ1DO@apples> (raw)
In-Reply-To: <20220420053336.GA2063@lst.de>

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Apr 20 07:33, Christoph Hellwig wrote:
> On Tue, Apr 19, 2022 at 02:10:38PM +0200, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > Do not default to generate an UUID for namespaces if it is not
> > explicitly specified.
> > 
> > This is a technically a breaking change in behavior. However, since the
> > UUID changes on every VM launch, it is not spec compliant and is of
> > little use since the UUID cannot be used reliably anyway and the
> > behavior prior to this patch must be considered buggy.
> 
> So unlike the EUI, UUIDs are designed to be autogenerated even if the
> current algorithm is completely broken.  We'd just need to persist them.
> Note that NVMe at least in theory requires providing at least on of
> the unique identifiers, and the UUID is the only one designed to be
> autogenerated in a distributed fashion.

I understand, but it boils down to the fact that we do not have a
general method of storing "metadata" like this persistently.

But maybe it is time that we come up with something to do this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-04-20  6:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 12:10 [PATCH 0/5] hw/nvme: fix namespace identifiers Klaus Jensen
2022-04-19 12:10 ` [PATCH 1/5] hw/nvme: enforce common serial per subsystem Klaus Jensen
2022-04-20  5:20   ` Christoph Hellwig
2022-04-19 12:10 ` [PATCH 2/5] hw/nvme: always set eui64 Klaus Jensen
2022-04-20  5:30   ` Christoph Hellwig
2022-04-20  5:48     ` Klaus Jensen
2022-04-20  6:02       ` Klaus Jensen
2022-04-19 12:10 ` [PATCH 3/5] hw/nvme: do not report null uuid Klaus Jensen
2022-04-20  5:31   ` Christoph Hellwig
2022-04-19 12:10 ` [PATCH 4/5] hw/nvme: do not auto-generate uuid Klaus Jensen
2022-04-20  5:33   ` Christoph Hellwig
2022-04-20  5:51     ` Klaus Jensen [this message]
2022-04-20  6:53       ` Christoph Hellwig
2022-04-20  6:58         ` Klaus Jensen
2022-04-19 12:10 ` [PATCH 5/5] hw/nvme: bump firmware revision Klaus Jensen
2022-04-19 14:32 ` [PATCH 0/5] hw/nvme: fix namespace identifiers Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl+fZI5kGW2wQ1DO@apples \
    --to=its@irrelevant.dk \
    --cc=hch@lst.de \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).