qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Damien Hedde <damien.hedde@greensocs.com>
Cc: Beraldo Leal <bleal@redhat.com>, Cleber Rosa <crosa@redhat.com>,
	John Snow <jsnow@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu
Date: Tue, 19 Apr 2022 18:18:53 +0100	[thread overview]
Message-ID: <Yl7u/ZnK2aJxiHVp@redhat.com> (raw)
In-Reply-To: <86b617c6-2cec-8570-5947-7e584fb1214b@greensocs.com>

On Tue, Apr 05, 2022 at 02:45:14PM +0200, Damien Hedde wrote:
> 
> 
> On 4/5/22 07:41, Markus Armbruster wrote:
> > Daniel P. Berrangé <berrange@redhat.com> writes:
> > 
> > > On Wed, Mar 16, 2022 at 10:54:55AM +0100, Damien Hedde wrote:
> > > > It takes an input file containing raw qmp commands (concatenated json
> > > > dicts) and send all commands one by one to a qmp server. When one
> > > > command fails, it exits.
> > > > 
> > > > As a convenience, it can also wrap the qemu process to avoid having
> > > > to start qemu in background. When wrapping qemu, the program returns
> > > > only when the qemu process terminates.
> > > > 
> > > > Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
> > 
> > [...]
> > 
> > > > I name that qmp-send as Daniel proposed, maybe qmp-test matches better
> > > > what I'm doing there ?
> > > 
> > > 'qmp-test' is a use case specific name. I think it is better to
> > > name it based on functionality provided rather than anticipated
> > > use case, since use cases evolve over time, hence 'qmp-send'.
> > 
> > Well, it doesn't just send, it also receives.
> > 
> > qmpcat, like netcat and socat?
> > 
> 
> anyone against qmpcat ?

Fine with me[1], though I would have slight preference for 'qmp-cat'
to have a common tab-completion prefix with existing qmp-shell command.

With regards,
Daniel

[1] Especially if it displays a pretty ascii art cat when you pass
    the --help flag ;-P
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2022-04-19 17:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  9:54 [RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu Damien Hedde
2022-03-16 10:24 ` Daniel P. Berrangé
2022-03-16 14:16   ` Damien Hedde
2022-04-05  5:41   ` Markus Armbruster
2022-04-05 12:45     ` Damien Hedde
2022-04-19 17:18       ` Daniel P. Berrangé [this message]
2022-04-20  6:28         ` Markus Armbruster
2022-04-04 20:34 ` John Snow
2022-04-05  9:02   ` Damien Hedde
2022-04-05  9:45     ` Markus Armbruster
2022-04-05 18:08     ` John Snow
2022-04-06  5:18       ` Markus Armbruster
2022-05-25 16:06 ` Daniel P. Berrangé
2022-05-30  7:12   ` Damien Hedde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl7u/ZnK2aJxiHVp@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=damien.hedde@greensocs.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).