* [PATCH] migration/dirtyrate: Replace malloc with g_new
@ 2022-04-11 9:47 jianchunfu
2022-04-11 11:30 ` Dr. David Alan Gilbert
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: jianchunfu @ 2022-04-11 9:47 UTC (permalink / raw)
To: richard.henderson; +Cc: qemu-devel, jianchunfu, dgilbert, quintela
Using macro g_new() to handling potential memory allocation failures
in dirtyrate.
Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
---
migration/dirtyrate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index aace12a787..0e59aacbb0 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -522,10 +522,10 @@ static void calculate_dirtyrate_dirty_ring(struct DirtyRateConfig config)
nvcpu++;
}
- dirty_pages = malloc(sizeof(*dirty_pages) * nvcpu);
+ dirty_pages = g_new(DirtyPageRecord, nvcpu);
DirtyStat.dirty_ring.nvcpu = nvcpu;
- DirtyStat.dirty_ring.rates = malloc(sizeof(DirtyRateVcpu) * nvcpu);
+ DirtyStat.dirty_ring.rates = g_new(DirtyRateVcpu, nvcpu);
dirtyrate_global_dirty_log_start();
--
2.18.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] migration/dirtyrate: Replace malloc with g_new
2022-04-11 9:47 [PATCH] migration/dirtyrate: Replace malloc with g_new jianchunfu
@ 2022-04-11 11:30 ` Dr. David Alan Gilbert
2022-04-11 18:08 ` Richard Henderson
2022-04-11 21:44 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2022-04-11 11:30 UTC (permalink / raw)
To: jianchunfu; +Cc: richard.henderson, qemu-devel, quintela
* jianchunfu (jianchunfu@cmss.chinamobile.com) wrote:
> Using macro g_new() to handling potential memory allocation failures
> in dirtyrate.
>
> Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
> ---
> migration/dirtyrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index aace12a787..0e59aacbb0 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -522,10 +522,10 @@ static void calculate_dirtyrate_dirty_ring(struct DirtyRateConfig config)
> nvcpu++;
> }
>
> - dirty_pages = malloc(sizeof(*dirty_pages) * nvcpu);
> + dirty_pages = g_new(DirtyPageRecord, nvcpu);
>
> DirtyStat.dirty_ring.nvcpu = nvcpu;
> - DirtyStat.dirty_ring.rates = malloc(sizeof(DirtyRateVcpu) * nvcpu);
> + DirtyStat.dirty_ring.rates = g_new(DirtyRateVcpu, nvcpu);
>
> dirtyrate_global_dirty_log_start();
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> --
> 2.18.4
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration/dirtyrate: Replace malloc with g_new
2022-04-11 9:47 [PATCH] migration/dirtyrate: Replace malloc with g_new jianchunfu
2022-04-11 11:30 ` Dr. David Alan Gilbert
@ 2022-04-11 18:08 ` Richard Henderson
2022-04-11 21:44 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2022-04-11 18:08 UTC (permalink / raw)
To: jianchunfu; +Cc: qemu-devel, dgilbert, quintela
On 4/11/22 02:47, jianchunfu wrote:
> Using macro g_new() to handling potential memory allocation failures
> in dirtyrate.
>
> Signed-off-by: jianchunfu<jianchunfu@cmss.chinamobile.com>
> ---
> migration/dirtyrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration/dirtyrate: Replace malloc with g_new
2022-04-11 9:47 [PATCH] migration/dirtyrate: Replace malloc with g_new jianchunfu
2022-04-11 11:30 ` Dr. David Alan Gilbert
2022-04-11 18:08 ` Richard Henderson
@ 2022-04-11 21:44 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-04-11 21:44 UTC (permalink / raw)
To: jianchunfu, richard.henderson; +Cc: quintela, qemu-devel, dgilbert
On 11/4/22 11:47, jianchunfu wrote:
> Using macro g_new() to handling potential memory allocation failures
> in dirtyrate.
>
> Signed-off-by: jianchunfu <jianchunfu@cmss.chinamobile.com>
> ---
> migration/dirtyrate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index aace12a787..0e59aacbb0 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -522,10 +522,10 @@ static void calculate_dirtyrate_dirty_ring(struct DirtyRateConfig config)
> nvcpu++;
> }
>
> - dirty_pages = malloc(sizeof(*dirty_pages) * nvcpu);
> + dirty_pages = g_new(DirtyPageRecord, nvcpu);
>
> DirtyStat.dirty_ring.nvcpu = nvcpu;
> - DirtyStat.dirty_ring.rates = malloc(sizeof(DirtyRateVcpu) * nvcpu);
> + DirtyStat.dirty_ring.rates = g_new(DirtyRateVcpu, nvcpu);
>
> dirtyrate_global_dirty_log_start();
>
While malloc() resources are released with free(), g_malloc/g_new()
ones with g_free().
So to match the API, this hunk is missing:
-- >8 --
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index aace12a787..e49db7ca4c 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -159,3 +159,3 @@ static void cleanup_dirtyrate_stat(struct
DirtyRateConfig config)
if (dirtyrate_mode == DIRTY_RATE_MEASURE_MODE_DIRTY_RING) {
- free(DirtyStat.dirty_ring.rates);
+ g_free(DirtyStat.dirty_ring.rates);
DirtyStat.dirty_ring.rates = NULL;
@@ -558,3 +558,3 @@ static void calculate_dirtyrate_dirty_ring(struct
DirtyRateConfig config)
DirtyStat.dirty_rate = dirtyrate_sum;
- free(dirty_pages);
+ g_free(dirty_pages);
}
---
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-11 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-11 9:47 [PATCH] migration/dirtyrate: Replace malloc with g_new jianchunfu
2022-04-11 11:30 ` Dr. David Alan Gilbert
2022-04-11 18:08 ` Richard Henderson
2022-04-11 21:44 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).