Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Apr 20, 2022 at 05:26:02PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> G_NORETURN was introduced in glib 2.68, fallback to G_GNUC_NORETURN in
> glib-compat.
> 
> Note that this attribute must be placed before the function declaration
> (bringing a bit of consistency in qemu codebase usage).
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  accel/tcg/internal.h                 |  3 +--
>  include/exec/exec-all.h              | 20 +++++++++---------
>  include/exec/helper-head.h           |  2 +-
>  include/glib-compat.h                |  4 ++++
>  include/hw/core/cpu.h                |  2 +-
>  include/hw/core/tcg-cpu-ops.h        |  6 +++---
>  include/hw/hw.h                      |  2 +-
>  include/qemu/compiler.h              |  2 --
>  include/qemu/osdep.h                 |  3 ++-
>  include/qemu/thread.h                |  2 +-
>  include/tcg/tcg-ldst.h               |  4 ++--
>  include/tcg/tcg.h                    |  2 +-
>  linux-user/user-internals.h          |  2 +-
>  scripts/cocci-macro-file.h           |  2 +-
>  target/alpha/cpu.h                   | 10 ++++-----
>  target/arm/internals.h               | 12 +++++------
>  target/hppa/cpu.h                    |  2 +-
>  target/i386/tcg/helper-tcg.h         | 24 ++++++++++-----------
>  target/microblaze/cpu.h              |  6 +++---
>  target/mips/tcg/tcg-internal.h       | 17 ++++++++-------
>  target/nios2/cpu.h                   |  6 +++---
>  target/openrisc/exception.h          |  2 +-
>  target/ppc/cpu.h                     | 14 ++++++-------
>  target/ppc/internal.h                |  6 +++---
>  target/riscv/cpu.h                   | 10 ++++-----
>  target/s390x/s390x-internal.h        |  6 +++---
>  target/s390x/tcg/tcg_s390x.h         | 12 +++++------
>  target/sh4/cpu.h                     |  6 +++---
>  target/sparc/cpu.h                   | 10 ++++-----
>  target/xtensa/cpu.h                  |  6 +++---
>  accel/stubs/tcg-stub.c               |  4 ++--
>  bsd-user/signal.c                    |  3 ++-
>  hw/misc/mips_itu.c                   |  3 ++-
>  linux-user/signal.c                  |  3 ++-
>  monitor/hmp.c                        |  4 ++--
>  qemu-img.c                           | 12 +++++++----
>  target/alpha/helper.c                | 10 ++++-----
>  target/arm/pauth_helper.c            |  4 ++--
>  target/arm/tlb_helper.c              |  7 ++++---
>  target/hexagon/op_helper.c           |  9 ++++----
>  target/hppa/cpu.c                    |  8 +++----
>  target/hppa/op_helper.c              |  4 ++--
>  target/i386/tcg/bpt_helper.c         |  2 +-
>  target/i386/tcg/excp_helper.c        | 31 ++++++++++++++--------------
>  target/i386/tcg/misc_helper.c        |  6 +++---
>  target/i386/tcg/sysemu/misc_helper.c |  7 ++++---
>  target/openrisc/exception.c          |  2 +-
>  target/openrisc/exception_helper.c   |  3 ++-
>  target/riscv/op_helper.c             |  4 ++--
>  target/rx/op_helper.c                | 22 +++++++++++---------
>  target/s390x/tcg/excp_helper.c       | 22 +++++++++++---------
>  target/sh4/op_helper.c               |  5 +++--
>  target/sparc/mmu_helper.c            |  8 +++----
>  target/tricore/op_helper.c           |  6 +++---
>  tcg/tcg.c                            |  3 ++-
>  tests/fp/fp-bench.c                  |  3 ++-
>  tests/fp/fp-test.c                   |  3 ++-
>  scripts/checkpatch.pl                |  2 +-
>  58 files changed, 214 insertions(+), 191 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|