From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85047C433EF for ; Wed, 20 Apr 2022 16:15:18 +0000 (UTC) Received: from localhost ([::1]:36786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhCz7-0006ME-Ft for qemu-devel@archiver.kernel.org; Wed, 20 Apr 2022 12:15:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhCPQ-0001Nb-Rw for qemu-devel@nongnu.org; Wed, 20 Apr 2022 11:38:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhCPO-0001hJ-D6 for qemu-devel@nongnu.org; Wed, 20 Apr 2022 11:38:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650469101; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gnpv3KkgyPbjodNngC8eYofXtlP3XYfvnfTUVaSkYL0=; b=E1z1EyUo2bBl/hUKagfb2Ue5gBDUYNwB07DM+IMNmD+lE5dlDnQJY9JUQ/xELXA1YoS2+P J81KmPxyQDr1FKrbqwWaKNuiKBxXp3c7+JncdG0MInUn8Crpj3hAw7YYOrTTW9LMhvOKW4 vI604IAAWgAZcEpCwX5/3eSxdiKNGS8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-Fcm5-PrbOUKaXca_7qX4Zg-1; Wed, 20 Apr 2022 11:38:20 -0400 X-MC-Unique: Fcm5-PrbOUKaXca_7qX4Zg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE82A86B8B8; Wed, 20 Apr 2022 15:38:19 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2F38C52C81; Wed, 20 Apr 2022 15:38:18 +0000 (UTC) Date: Wed, 20 Apr 2022 16:38:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Subject: Re: [PATCH 23/41] include: add qemu/keyval.h Message-ID: References: <20220420132624.2439741-1-marcandre.lureau@redhat.com> <20220420132624.2439741-24-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220420132624.2439741-24-marcandre.lureau@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , Michael Roth , Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Apr 20, 2022 at 05:26:06PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Do not require the whole option machinery to handle keyval, as it is > used by QAPI alone, without the option API. And match the associated > unit name. Great, I really dislike it when the .h file name doesn't match the name where I'll find the .c file impl > > Signed-off-by: Marc-André Lureau > --- > include/qemu/keyval.h | 14 ++++++++++++++ > include/qemu/option.h | 6 ------ > qapi/qobject-input-visitor.c | 2 +- > qom/object_interfaces.c | 1 + > softmmu/vl.c | 1 + > tests/unit/check-qom-proplist.c | 1 + > tests/unit/test-forward-visitor.c | 2 +- > tests/unit/test-keyval.c | 2 +- > util/keyval.c | 2 +- > 9 files changed, 21 insertions(+), 10 deletions(-) > create mode 100644 include/qemu/keyval.h Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|