* [PATCH] migration: Fix operator type
@ 2022-04-06 10:25 Dr. David Alan Gilbert (git)
2022-04-06 12:11 ` Peter Maydell
2022-04-06 12:18 ` Peter Xu
0 siblings, 2 replies; 4+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2022-04-06 10:25 UTC (permalink / raw)
To: qemu-devel, quintela; +Cc: leobras, peterx
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Clang spotted an & that should have been an &&; fix it.
Reported by: David Binderman / https://gitlab.com/dcb
Fixes: 65dacaa04fa ("migration: introduce save_normal_page()")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/963
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 3532f64ecb..0ef4bd63eb 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1289,7 +1289,7 @@ static int save_normal_page(RAMState *rs, RAMBlock *block, ram_addr_t offset,
offset | RAM_SAVE_FLAG_PAGE));
if (async) {
qemu_put_buffer_async(rs->f, buf, TARGET_PAGE_SIZE,
- migrate_release_ram() &
+ migrate_release_ram() &&
migration_in_postcopy());
} else {
qemu_put_buffer(rs->f, buf, TARGET_PAGE_SIZE);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: Fix operator type
2022-04-06 10:25 [PATCH] migration: Fix operator type Dr. David Alan Gilbert (git)
@ 2022-04-06 12:11 ` Peter Maydell
2022-04-06 12:18 ` Peter Xu
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2022-04-06 12:11 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: leobras, qemu-devel, peterx, quintela
On Wed, 6 Apr 2022 at 11:31, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Clang spotted an & that should have been an &&; fix it.
>
> Reported by: David Binderman / https://gitlab.com/dcb
> Fixes: 65dacaa04fa ("migration: introduce save_normal_page()")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/963
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 3532f64ecb..0ef4bd63eb 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1289,7 +1289,7 @@ static int save_normal_page(RAMState *rs, RAMBlock *block, ram_addr_t offset,
> offset | RAM_SAVE_FLAG_PAGE));
> if (async) {
> qemu_put_buffer_async(rs->f, buf, TARGET_PAGE_SIZE,
> - migrate_release_ram() &
> + migrate_release_ram() &&
> migration_in_postcopy());
> } else {
> qemu_put_buffer(rs->f, buf, TARGET_PAGE_SIZE);
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: Fix operator type
2022-04-06 10:25 [PATCH] migration: Fix operator type Dr. David Alan Gilbert (git)
2022-04-06 12:11 ` Peter Maydell
@ 2022-04-06 12:18 ` Peter Xu
2022-04-21 14:04 ` Dr. David Alan Gilbert
1 sibling, 1 reply; 4+ messages in thread
From: Peter Xu @ 2022-04-06 12:18 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: leobras, qemu-devel, quintela
On Wed, Apr 06, 2022 at 11:25:15AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Clang spotted an & that should have been an &&; fix it.
>
> Reported by: David Binderman / https://gitlab.com/dcb
> Fixes: 65dacaa04fa ("migration: introduce save_normal_page()")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/963
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: Fix operator type
2022-04-06 12:18 ` Peter Xu
@ 2022-04-21 14:04 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2022-04-21 14:04 UTC (permalink / raw)
To: Peter Xu; +Cc: leobras, qemu-devel, quintela
* Peter Xu (peterx@redhat.com) wrote:
> On Wed, Apr 06, 2022 at 11:25:15AM +0100, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Clang spotted an & that should have been an &&; fix it.
> >
> > Reported by: David Binderman / https://gitlab.com/dcb
> > Fixes: 65dacaa04fa ("migration: introduce save_normal_page()")
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/963
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
Queued
> --
> Peter Xu
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-21 14:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-06 10:25 [PATCH] migration: Fix operator type Dr. David Alan Gilbert (git)
2022-04-06 12:11 ` Peter Maydell
2022-04-06 12:18 ` Peter Xu
2022-04-21 14:04 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).