From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: Re: [PATCH 06/10] Replace qemu_pipe() with g_unix_open_pipe()
Date: Fri, 22 Apr 2022 09:59:57 +0100 [thread overview]
Message-ID: <YmJujaGAGJLDtMzL@redhat.com> (raw)
In-Reply-To: <20220422083639.3156978-7-marcandre.lureau@redhat.com>
On Fri, Apr 22, 2022 at 12:36:35PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> GLib g_unix_open_pipe() is essentially like qemu_pipe(), available since
> 2.30.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu/osdep.h | 4 ----
> qemu-nbd.c | 5 +++--
> util/event_notifier-posix.c | 2 +-
> util/oslib-posix.c | 22 ----------------------
> 4 files changed, 4 insertions(+), 29 deletions(-)
There are a bunch of places still using 'pipe'instead of 'qemu_pipe'
that should be switched also.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-04-22 9:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 8:36 [PATCH 00/10] Misc cleanups marcandre.lureau
2022-04-22 8:36 ` [PATCH 01/10] Use QEMU_SANITIZE_THREAD marcandre.lureau
2022-04-22 8:36 ` [PATCH 02/10] Use QEMU_SANITIZE_ADDRESS marcandre.lureau
2022-04-22 8:36 ` [PATCH 03/10] include: move qemu_*_exec_dir() to cutils marcandre.lureau
2022-04-22 8:36 ` [PATCH 04/10] tests: move libqtest.h back under qtest/ marcandre.lureau
2022-04-25 19:32 ` Thomas Huth
2022-04-22 8:36 ` [PATCH 05/10] libqtest: split QMP part in libqmp marcandre.lureau
2022-04-25 19:39 ` Thomas Huth
2022-04-22 8:36 ` [PATCH 06/10] Replace qemu_pipe() with g_unix_open_pipe() marcandre.lureau
2022-04-22 8:59 ` Daniel P. Berrangé [this message]
2022-04-22 9:09 ` Marc-André Lureau
2022-04-22 8:36 ` [PATCH 07/10] tests: make libqmp buildable for win32 marcandre.lureau
2022-04-22 8:36 ` [PATCH 08/10] Use g_unix_set_fd_nonblocking() marcandre.lureau
2022-04-22 8:56 ` Daniel P. Berrangé
2022-04-22 9:06 ` Marc-André Lureau
2022-04-22 14:24 ` Eric Blake
2022-04-22 14:27 ` Marc-André Lureau
2022-04-22 8:36 ` [PATCH 09/10] block: move fcntl_setfl() marcandre.lureau
2022-04-22 12:20 ` Richard Henderson
2022-04-22 8:36 ` [PATCH 10/10] util/win32: simplify qemu_get_local_state_dir() marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmJujaGAGJLDtMzL@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).