From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ED97C433F5 for ; Fri, 22 Apr 2022 09:14:28 +0000 (UTC) Received: from localhost ([::1]:49030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhpMx-0004vi-IB for qemu-devel@archiver.kernel.org; Fri, 22 Apr 2022 05:14:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhp95-0000wv-BW for qemu-devel@nongnu.org; Fri, 22 Apr 2022 05:00:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:46368) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhp93-00017Y-6t for qemu-devel@nongnu.org; Fri, 22 Apr 2022 05:00:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650618004; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W1D1qelEmYNvZ4OZOfzCETglRMYWw1DpTPahMMLl1RU=; b=OytPo05KrIbdtOZn7xjCw521uleLjFZ3OCeSkZY3RA0/446mk66Wjins7ly0Su9irKV51F uaZL9gRCexwCalJt2RrjVIlY0MV+Me33GqRvn89muWYYX1Wp/vo+RQKy5zGmJRlQnJB4qC S8khCI0vw+PAssU4IzaFA+f2a/d2+fg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-599-nZlQYz2ZOwesFm89JJ7hFA-1; Fri, 22 Apr 2022 05:00:03 -0400 X-MC-Unique: nZlQYz2ZOwesFm89JJ7hFA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 195F83839742; Fri, 22 Apr 2022 09:00:03 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72D8C145BF02; Fri, 22 Apr 2022 09:00:00 +0000 (UTC) Date: Fri, 22 Apr 2022 09:59:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Subject: Re: [PATCH 06/10] Replace qemu_pipe() with g_unix_open_pipe() Message-ID: References: <20220422083639.3156978-1-marcandre.lureau@redhat.com> <20220422083639.3156978-7-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220422083639.3156978-7-marcandre.lureau@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , Vladimir Sementsov-Ogievskiy , Eric Blake , qemu-devel@nongnu.org, "open list:Network Block Dev..." Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Apr 22, 2022 at 12:36:35PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > GLib g_unix_open_pipe() is essentially like qemu_pipe(), available since > 2.30. > > Signed-off-by: Marc-André Lureau > --- > include/qemu/osdep.h | 4 ---- > qemu-nbd.c | 5 +++-- > util/event_notifier-posix.c | 2 +- > util/oslib-posix.c | 22 ---------------------- > 4 files changed, 4 insertions(+), 29 deletions(-) There are a bunch of places still using 'pipe'instead of 'qemu_pipe' that should be switched also. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|